Skip to content

Commit a15f6b8

Browse files
Fix notification service
Add parameter to not overwrite buildsettings
1 parent f23cf8e commit a15f6b8

File tree

6 files changed

+83
-43
lines changed

6 files changed

+83
-43
lines changed

step/platform.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -56,7 +56,7 @@ func (p XcodeProjWrapper) BuildSettings(scheme, configuration string, customOpti
5656
commandModel.SetScheme(scheme)
5757
commandModel.SetConfiguration(configuration)
5858
commandModel.SetCustomOptions(customOptions)
59-
return commandModel.RunAndReturnSettings()
59+
return commandModel.RunAndReturnSettings(false)
6060
}
6161

6262
func (p XcodeProjWrapper) GetProject() (*xcodeproj.XcodeProj, error) {

step/step.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -387,7 +387,7 @@ func (s XcodebuildArchiver) Run(opts RunOpts) (RunResult, error) {
387387
cmdModel := xcodebuild.NewShowBuildSettingsCommand(opts.ProjectPath)
388388
cmdModel.SetScheme(opts.Scheme)
389389
cmdModel.SetConfiguration(opts.Configuration)
390-
settings, err := cmdModel.RunAndReturnSettings()
390+
settings, err := cmdModel.RunAndReturnSettings(false)
391391
if err != nil {
392392
return out, fmt.Errorf("failed to read build settings: %w", err)
393393
}

vendor/github.com/bitrise-io/go-xcode/v2/autocodesign/projectmanager/projecthelper.go

Lines changed: 58 additions & 34 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

vendor/github.com/bitrise-io/go-xcode/xcodebuild/show_build_settings.go

Lines changed: 21 additions & 5 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

vendor/github.com/bitrise-io/go-xcode/xcodeproject/xcodeproj/xcodeproj.go

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

vendor/github.com/bitrise-io/go-xcode/xcodeproject/xcworkspace/xcworkspace.go

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)