Skip to content

Commit 340f3f6

Browse files
authored
strip custom export options, fixed scheme - targets mapping, fixed xc… (#85)
* strip custom export options, fixed scheme - targets mapping, fixed xcode managed profile detection * trim space fix * pr fix
1 parent e958690 commit 340f3f6

File tree

34 files changed

+60
-7309
lines changed

34 files changed

+60
-7309
lines changed

Godeps/Godeps.json

Lines changed: 13 additions & 33 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

main.go

Lines changed: 24 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -101,22 +101,10 @@ func createConfigsModelFromEnvs() ConfigsModel {
101101

102102
func (configs ConfigsModel) print() {
103103
log.Infof("ipa export configs:")
104-
105-
useCustomExportOptions := (configs.CustomExportOptionsPlistContent != "")
106-
if useCustomExportOptions {
107-
fmt.Println()
108-
log.Warnf("Ignoring the following options because CustomExportOptionsPlistContent provided:")
109-
}
110-
111104
log.Printf("- ExportMethod: %s", configs.ExportMethod)
112105
log.Printf("- UploadBitcode: %s", configs.UploadBitcode)
113106
log.Printf("- CompileBitcode: %s", configs.CompileBitcode)
114107
log.Printf("- TeamID: %s", configs.TeamID)
115-
116-
if useCustomExportOptions {
117-
log.Warnf("----------")
118-
}
119-
120108
log.Printf("- UseDeprecatedExport: %s", configs.UseDeprecatedExport)
121109
log.Printf("- CustomExportOptionsPlistContent:")
122110
if configs.CustomExportOptionsPlistContent != "" {
@@ -340,27 +328,46 @@ or use 'xcodebuild' as 'output_tool'.`)
340328
}
341329

342330
// Validation CustomExportOptionsPlistContent
343-
if configs.CustomExportOptionsPlistContent != "" &&
344-
xcodeMajorVersion < 7 {
345-
log.Warnf("CustomExportOptionsPlistContent is set, but CustomExportOptionsPlistContent only used if xcodeMajorVersion > 6")
346-
configs.CustomExportOptionsPlistContent = ""
331+
customExportOptionsPlistContent := strings.TrimSpace(configs.CustomExportOptionsPlistContent)
332+
if customExportOptionsPlistContent != configs.CustomExportOptionsPlistContent {
333+
fmt.Println()
334+
log.Warnf("CustomExportOptionsPlistContent is stripped to remove spaces and new lines:")
335+
log.Printf(customExportOptionsPlistContent)
336+
}
337+
338+
if customExportOptionsPlistContent != "" {
339+
if xcodeMajorVersion < 7 {
340+
fmt.Println()
341+
log.Warnf("CustomExportOptionsPlistContent is set, but CustomExportOptionsPlistContent only used if xcodeMajorVersion > 6")
342+
customExportOptionsPlistContent = ""
343+
} else {
344+
fmt.Println()
345+
log.Warnf("Ignoring the following options because CustomExportOptionsPlistContent provided:")
346+
log.Printf("- ExportMethod: %s", configs.ExportMethod)
347+
log.Printf("- UploadBitcode: %s", configs.UploadBitcode)
348+
log.Printf("- CompileBitcode: %s", configs.CompileBitcode)
349+
log.Printf("- TeamID: %s", configs.TeamID)
350+
fmt.Println()
351+
}
347352
}
348353

349-
customExportOptionsPlistContent := strings.TrimSpace(configs.CustomExportOptionsPlistContent)
350354
if configs.ForceProvisioningProfileSpecifier != "" &&
351355
xcodeMajorVersion < 8 {
356+
fmt.Println()
352357
log.Warnf("ForceProvisioningProfileSpecifier is set, but ForceProvisioningProfileSpecifier only used if xcodeMajorVersion > 7")
353358
configs.ForceProvisioningProfileSpecifier = ""
354359
}
355360

356361
if configs.ForceTeamID != "" &&
357362
xcodeMajorVersion < 8 {
363+
fmt.Println()
358364
log.Warnf("ForceTeamID is set, but ForceTeamID only used if xcodeMajorVersion > 7")
359365
configs.ForceTeamID = ""
360366
}
361367

362368
if configs.ForceProvisioningProfileSpecifier != "" &&
363369
configs.ForceProvisioningProfile != "" {
370+
fmt.Println()
364371
log.Warnf("both ForceProvisioningProfileSpecifier and ForceProvisioningProfile are set, using ForceProvisioningProfileSpecifier")
365372
configs.ForceProvisioningProfile = ""
366373
}

vendor/github.com/bitrise-io/steps-certificate-and-profile-installer/profileutil/profileutil.go

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

vendor/github.com/bitrise-tools/go-xcode/xcodeproj/code_sign_info_script.go

Lines changed: 11 additions & 8 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

vendor/github.com/bitrise-tools/go-xcode/xcodeproj/code_sign_info_script.rb

Lines changed: 11 additions & 8 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

vendor/github.com/davecgh/go-spew/LICENSE

Lines changed: 0 additions & 15 deletions
This file was deleted.

0 commit comments

Comments
 (0)