App Store Connect API: fix tracking non-200 responses (#274)

* App Store Connect API: fix tracking non-200 responses

* Fix test

Author: ofalvai

autocodesign/devportalclient/appstoreconnect/appstoreconnect.go

@@ -276,6 +276,7 @@ func (c *Client) Do(req *http.Request, v interface{}) (*http.Response, error) {
 	}()
 
 	if err := checkResponse(resp); err != nil {
+		c.tracker.TrackAPIRequest(req.Method, req.URL.Host, req.URL.Path, resp.StatusCode, duration)
 		c.tracker.TrackAPIError(req.Method, req.URL.Host, req.URL.Path, resp.StatusCode, err.Error())
 		return resp, err
 	}

autocodesign/devportalclient/appstoreconnect/appstoreconnect_test.go

@@ -152,7 +152,7 @@ func TestTracking(t *testing.T) {
 
 		require.True(t, mockHTTPClient.called, "Expected HTTP client to be called")
 
-		require.Len(t, mockTracker.apiRequests, 0, "Expected 0 (successful) API requests tracked")
+		require.Len(t, mockTracker.apiRequests, 1, "Expected 1 (failed) API requests tracked")
 		require.Len(t, mockTracker.apiErrors, 1, "Expected 1 API error tracked")
 
 		errorRecord := mockTracker.apiErrors[0]