[github-actions] Add index-monitor action #31378
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
verify
carrodher
previously approved these changes
Jan 15, 2025
|
mmm... Shouldn't this PR be created using the |
Signed-off-by: Miguel Ruiz <[email protected]>
migruiz4
force-pushed
the
index-monitor
branch
from
da9f712 to
9f4619d
Compare
Signed-off-by: Miguel Ruiz <[email protected]>
jotamartos
previously approved these changes
Jan 16, 2025
Signed-off-by: Miguel Ruiz <[email protected]>
carrodher
approved these changes
Jan 16, 2025
fmulero
reviewed
Jan 16, 2025
Comment on lines
+48
to
+57
| echo "result=${status}" >> $GITHUB_OUTPUT | ||
| - name: Show messages | ||
| uses: actions/github-script@60a0d83039c74a4aee543508d2ffcb1c3799cdea | ||
| with: | ||
| script: | | ||
| if ("${{ steps.integrity-check.outputs.result }}" != "ok" ) { | ||
| core.setFailed("Integrity check failed"); | ||
| } else { | ||
| core.info("Integrity check succeeded") | ||
| } |
There was a problem hiding this comment.
I think we could simplify this piece of code with something like this:
Suggested change
| echo "result=${status}" >> $GITHUB_OUTPUT | |
| - name: Show messages | |
| uses: actions/github-script@60a0d83039c74a4aee543508d2ffcb1c3799cdea | |
| with: | |
| script: | | |
| if ("${{ steps.integrity-check.outputs.result }}" != "ok" ) { | |
| core.setFailed("Integrity check failed"); | |
| } else { | |
| core.info("Integrity check succeeded") | |
| } | |
| if [[ "${status}" != "ok" ]]; then | |
| echo "::error:: Integrity check failed" | |
| else | |
| echo "::info:: Integrity check succeeded" | |
| fi | |
| echo "result=${status}" >> $GITHUB_OUTPUT |
Comment on lines
+94
to
+103
| echo "result=${status}" >> $GITHUB_OUTPUT | ||
| - name: Show messages | ||
| uses: actions/github-script@60a0d83039c74a4aee543508d2ffcb1c3799cdea | ||
| with: | ||
| script: | | ||
| if ("${{ steps.validation-check.outputs.result }}" != "ok" ) { | ||
| core.setFailed("Validation check failed"); | ||
| } else { | ||
| core.info("Validation check succeeded") | ||
| } |
There was a problem hiding this comment.
Same here:
Suggested change
| echo "result=${status}" >> $GITHUB_OUTPUT | |
| - name: Show messages | |
| uses: actions/github-script@60a0d83039c74a4aee543508d2ffcb1c3799cdea | |
| with: | |
| script: | | |
| if ("${{ steps.validation-check.outputs.result }}" != "ok" ) { | |
| core.setFailed("Validation check failed"); | |
| } else { | |
| core.info("Validation check succeeded") | |
| } | |
| if [[ "${status}" != "ok" ]]; then | |
| echo "::error:: Validation check failed" | |
| else | |
| echo "::info:: Validation check succeeded" | |
| fi | |
| echo "result=${status}" >> $GITHUB_OUTPUT |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change
Adds the new workflow 'index-monitor.yml'.
This new workflow will be executed in a schedule every 10 minutes and will be in charge of checking the integrity of the index.yaml file available at
Benefits
These changes aim to prevent the recent index failures, which we suspect may be related to the upload of the index.yaml available at 'http://charts.bitnami.com/bitnami/index.yaml'.
If consistent failures are detected (failed 3 times in a row), notifies the error and triggers a new index upload to immediately amend the issues.
Additional information
The workflow consists of 2 checks:
The integrity check will verify the index.yaml available in the 'index' branch matches the one available at 'http://charts.bitnami.com/bitnami/index.yaml'.
The validation check will test that the commands
helm repo addandhelm repo updatecan be executed successfully.Fixes Repository invalid? skipping loading invalid entry for chart "airflow" "" from https://charts.bitnami.com/bitnami: validation: chart.metadata.name is require #31350
Checklist
Chart.yamlaccording to semver. This is not necessary when the changes only affect README.md files.README.mdusing readme-generator-for-helm