-
Notifications
You must be signed in to change notification settings - Fork 9.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🔊 New container images security assessments #30850
Comments
This change breaks the service upgrade, as the the Helm chart's templates no longer complete evaluation when using values that previously compatible with the deployed configuration. This isn't a minor version update of the Helm chart. |
It appears that this breaking change was introduced to align with, and potentially promote, your new commercial offering rather than serving a purely technical or user-driven purpose.
Claiming that this change enhances security is not entirely accurate. Using the default image does not inherently guarantee the integrity of the deployed image, as true verification can only be achieved by validating its hash. Likewise, using a different image does not necessarily result in a less secure deployment. I therefore see the name of this parameter as counterintuitive and misleading. |
what about the official |
If I enable |
I'd suggest to follow the sem version policy strictly. If this is a minor version release, the default value of |
Helper checks image URL, breaking all mirrors and pull-through caches, even if used image is the official one. |
maybe instead of declaring everything except bitnami as insecure maybe let us decide which sources are trustworthy? |
There seems to be no interest from Bitnami to change anything... This is obviously a push for Bitnami premium. It's obviously fine that you want to profit from your work, but stating that non-bitnami repositories are, by default, unsafe and a security flaw is not only wrong but ethically questionable. With no changes to this policy don't expect me to buy anything from Bitnami. I know I'm just a drop in the bucket, but since our words are not being listened to, maybe our money will. |
This is the first step in monetizing. We already have examples of this strategy. Open source has started to be more like a temporary mask until they hook you, and after that, you are forced to pay, already hooked. I have nothing against making money, but don't use the principle of "open source" and then you force users to use their card. More and more I want to shift to the old school where open source was driven 100% by communities and not companies. I see big companies getting into the open source (and I was happy about it) but I was so naive! I think they want to control the open source tro' all kinds of "best practices and security"! Risks will always be. Every time you step out of your house you increase the risk of happening something to you. This means I don't need to step out of my house ? Shame on you! No worries I will build my own charts, I don't need yours! Like this, I will keep my freedom! |
It's all okay guys... just add |
I don't quite understand, why is bitnami marking its own images as unsafe to use? I was using I only use this for local dev so its not too much of a problem, but its weird. |
I work in an environment where all images, including in this case official Bitnami images, get pulled through a proxy. This change has resulted in applications which break when they get moved or recreated (in my environment, these operations result in the templates getting re-evaluated). This is not acceptable for a "minor" change (clearly violates semver - If this supply chain integrity check were to be implemented properly (by evaluating the pulled image, eg. comparing a hash of the image to what is expected), rather than just checking where the image gets pulled from, this would have caused no problems. |
This is even more relevant now that docker-hub has changed policies. For unauthenticated users there will be a limit of 10 pull/h. Both Bitnami's images and charts are hosted on docker-hub now. So a pull-through cache is practically a must. This means that I will need to set |
allow third images to be deployed by the chart, related to bitnami/charts#30850 and https://camunda.slack.com/archives/C03UR0V2R2M/p1741002015819099
I just find out something that invalidates my previous statement. bitnami and bitnamicharts are a DockerHub Verified Publishers. This means that DockerHub pull rate limiting is not applied for their images and charts. So it's a problem no more (at least for now). That said, I will go ahead and setup a pull-through cache with Harbor anyway just to be safe if docker changes its policy in the future. |
Funny how Bitnami's own images are considered insecure
|
One side-effect of this that I don't think has been considered are usecases where the bitnami charts are installed as subcharts to a bigger chart. If I personally would prefer if this were a setting in the chart-level such as |
What's the point of this check if I can mirror the registry in the container runtime configuration? |
…rt (#318) allow third images to be deployed by the chart, related to bitnami/charts#30850 and https://camunda.slack.com/archives/C03UR0V2R2M/p1741002015819099
@davgia I don't find any mention of that on https://www.docker.com/blog/revisiting-docker-hub-policies-prioritizing-developer-experience/ but also seems to contradict the following quote from #30853
|
Also just because you can pull them without rate limting from docker hub doesn't mean you want to. There are security concerns out there which make you want to remove public "random" internet access from your cluster nodes. in that case you want to have PTC through a "trusted" registry (e.g. AWS ECR). in that case everything is pulled through a PTC but still the official image. |
Can this be adapted to |
Might be worth adding an exception for "official" mirrors – such as https://gallery.ecr.aws/bitnami/. Also, with many mirrors out there, there's even no mention of what source is considered the "official" images anywhere? |
@claytonchew it seems that mirror isn't even "official" anymore. The blogpost announcing it's official is gone, no more mention of it on the website etc |
On December 10th, 2024, we released a minor version for every Helm chart in the Bitnami catalog. This minor version introduced a new security mechanism to detect the usage of non-standard containers while installing or upgrading Helm chart releases.
Replacing the original containers that are shipped with the charts will result in installation errors like the one below:
FAQ
Why did Bitnami introduce this mechanism?
There are several reasons to introduce this change:
Can I use different image tags?
Yes, replacing default image tags is considered a valid use case. For instance, a user might be interested in using the Bitnami PostgreSQL chart using Bitnami PostgreSQL 15.x container images (note the chart uses 16.x images by default).
That said, it is expected that you see some warnings on the chart notes given that the specific chart & image combination wasn't tested and validated by Bitnami on any platform.
Can I skip the security verification?
Yes, we introduced a new global parameter on every chart that can be used for that purpose, see:
At your own risk, you bypass the verification specifying the parameter adding the
--set global.security.allowInsecureImages=true
argument tohelm install
orhelm upgrade
commands or, alternatively, adding the block below to your values YAML file:Should I expect any issues upgrading my existing chart releases?
No issue is expected if you upgrade your existing releases using original container images. If you replace them, you'll have to skip the security verification.
Should I expect errors consuming Bitnami charts from mirror registries?
Yes. It is expected that you face installation errors while consuming Bitnami chart from mirror registries given the security mechanism will detect original images are not used. To continue using mirror registries, you'll have to skip the security verification.
I built my custom image extending a Bitnami container image, should I expect errors?
Yes. Custom images, even if they're extensions of original Bitnami container images, would be detected by the security mechanism and it is expected to face installation errors. To use your custom image, you'll have to skip the security verification at your own risk.
The text was updated successfully, but these errors were encountered: