Skip to content

No text input validation on proxyip settings #166

@bigshiny90

Description

@bigshiny90

Is there an existing issue for this?

  • I have searched the existing issues

Current behaviour

Settings -> Network -> proxyip input fields (socks5 and tor socks5) don't properly validate incorrect input (empty, improper ip format) and it allows saving the settings with incorrect or empty input. After a restart, node will not start until settings.json is manually edited to fix.

Image

Expected behaviour

all proxyip text fields should be validated for incorrect input and disallow saving until corrected

Steps to reproduce

Open Settings -> Network, check "Connect through SOCKS5 proxy" and input incorrect ip format or empty text.

Relevant log output

How did you obtain Bitcoin Knots

Compiled from source

What version of Bitcoin Knots are you using?

v28, v29rc

Operating system and version

ANY

Machine specifications

No response

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions