Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore[chain,wallet]: fix build warnings #1774

Merged
merged 1 commit into from
Dec 13, 2024
Merged

chore[chain,wallet]: fix build warnings #1774

merged 1 commit into from
Dec 13, 2024

Conversation

notmandatory
Copy link
Member

@notmandatory notmandatory commented Dec 12, 2024 •
edited
Loading

Description

fixed #1773

Notes to the reviewers

I noticed these warnings while publishing beta.6 and would like to get them fixed before the final bdk_wallet 1.0.0. With default features we should have any build warnings. To reproduce:

cargo build -p bdk_chain
cargo build -p bdk_wallet

Checklists

All Submissions:

  • I've signed all my commits
  • I followed the contribution guidelines
  • I ran cargo fmt and cargo clippy before committing

@notmandatory notmandatory self-assigned this Dec 12, 2024
@notmandatory notmandatory added this to the 1.0.0-beta milestone Dec 12, 2024
oleonardolima
oleonardolima reviewed Dec 12, 2024
View reviewed changes
Copy link
Contributor

@oleonardolima oleonardolima left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tACK

It looks good to me. However the only warning I was able to reproduce locally (prior to this fix) was the one in bdk_wallet. Also you might want to update the commit message to use chore(chain,wallet): instead of [...].

@notmandatory notmandatory force-pushed the chore/fix_build_warnings branch from bd6eca0 to 479117c Compare December 12, 2024 15:19
@notmandatory
Copy link
Member Author

It looks good to me. However the only warning I was able to reproduce locally (prior to this fix) was the one in bdk_wallet. Also you might want to update the commit message to use chore(chain,wallet): instead of [...].

@oleonardolima what version of rust are you using? I'm on 1.83.0, maybe it's a new warning? I can repro with the above commands in the description on master branch. Thanks for catching the weird commit message, I don't know why I did that! haha.

@oleonardolima
Copy link
Contributor

It looks good to me. However the only warning I was able to reproduce locally (prior to this fix) was the one in bdk_wallet. Also you might want to update the commit message to use chore(chain,wallet): instead of [...].

@oleonardolima what version of rust are you using? I'm on 1.83.0, maybe it's a new warning? I can repro with the above commands in the description on master branch. Thanks for catching the weird commit message, I don't know why I did that! haha.

Yes, that was the issue. I've tested with 1.83.0 and was able to reproduce the issue (I had the 1.80.1 before.

ValuedMammal
ValuedMammal approved these changes Dec 13, 2024
View reviewed changes
Copy link
Contributor

@ValuedMammal ValuedMammal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 479117c

@ValuedMammal
Copy link
Contributor

Thank you @notmandatory

@notmandatory notmandatory merged commit dbc6a1e into bitcoindevkit:master Dec 13, 2024
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oleonardolima oleonardolima oleonardolima left review comments

@ValuedMammal ValuedMammal ValuedMammal approved these changes

Assignees

@notmandatory notmandatory

Labels
chore
Projects
BDK
Archived in project
Milestone
1.0.0-beta
Development

Successfully merging this pull request may close these issues.

Fix build warnings
3 participants
@notmandatory @oleonardolima @ValuedMammal