RUSTSEC-2021-0145: Potential unaligned read

[github-actions]

Details
Package	atty
Version	0.2.14
Warning	unsound
URL	softprops/atty#50
Patched Versions	n/a
Aliases	GHSA-g98v-hv3f-hcfr

On windows, atty dereferences a potentially unaligned pointer.

In practice however, the pointer won't be unaligned unless a custom global allocator is used.

In particular, the System allocator on windows uses HeapAlloc, which guarantees a large enough alignment.

atty is Unmaintained

A Pull Request with a fix has been provided over a year ago but the maintainer seems to be unreachable.

Last release of atty was almost 3 years ago.

Possible Alternative(s)

The below list has not been vetted in any way and may or may not contain alternatives;

• std::io::IsTerminal - Stable since Rust 1.70.0
• is-terminal - Standalone crate supporting Rust older than 1.70.0

[oleonardolima]

A possible solution is bumping the criterion crate (when possible), it's related to #1769. See #1769 (comment)

[notmandatory]

I bumped the criterion crate to 0.5 in 1776 which should resolve this issue. I had to change this crate back to 0.2 so we can run tests with MSRV.