Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Geo Python Tracking Script #199

Closed
wants to merge 1 commit into from
Closed

Geo Python Tracking Script #199

wants to merge 1 commit into from

Conversation

larymak
Copy link

@larymak larymak commented Oct 20, 2020

Description

A python Script to locate any IP Address to get its exact location

Fixed #(198)

Replace #198 with the issue number which is fixed in this PR

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
  • Documentation Update

Checklist:

  • My code follows the style guidelines(Clean Code) of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Congratulations!! 🎉 @larymak for making your first PR. Admin will review the changes soon and merge finally.😊 Do give a star ⭐ if you like this project.

Copy link
Owner

@bislara bislara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great. Just a few changes that I will suggest.

  • Add a readme file inside the project folder
  • In the readme, add a screenshot, of how the application is looking
  • In the readme, write a little bit more how to set up and run the file so that a newbie can also test this application

@bislara bislara linked an issue Oct 21, 2020 that may be closed by this pull request
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Geo-IP Tracker
2 participants