Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

added video-to-gif #237

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

added video-to-gif #237

wants to merge 5 commits into from

Conversation

amannv2
Copy link

@amannv2 amannv2 commented Nov 5, 2020 •
edited
Loading

Added video to gif functionality

@github-actions github-actions bot requested a review from bislara November 5, 2020 06:40
bislara
bislara requested changes Nov 6, 2020
View reviewed changes
Copy link
Owner

@bislara bislara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey, can you put some output gif inside your project folder as well put it in the readme?
Rest all seems good.

@github-actions github-actions bot requested a review from bislara November 6, 2020 06:57
@bislara bislara linked an issue Nov 9, 2020 that may be closed by this pull request
Video to Gif #119
Open
@bislara
Copy link
Owner

bislara commented Nov 9, 2020

Hey, @amannv2 you just add a sample video file, not the output gif file. Add that also inside the project folder.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bislara bislara Awaiting requested review from bislara

Assignees

@amannv2 amannv2

Labels
requested-change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Video to Gif
2 participants
@amannv2 @bislara