Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unexpected cell behavior during plating #520

Open
charles-cowart opened this issue May 20, 2019 · 1 comment
Open

Unexpected cell behavior during plating #520

charles-cowart opened this issue May 20, 2019 · 1 comment
Assignees
@fedarko @qiyunzhu @charles-cowart
Milestone
Full Launch

Comments

@charles-cowart
Copy link
Collaborator

  • A copy/paste operation on a cell blows away everything in the cell, not just any highlighted text in the cell, this is not normal behavior.
  • Users can't multi select cells and clear contents using the delete key. This is also expected behavior.
  • If you copy/paste a specimen_id (be it sample_id, tube_id, etc.) into a cell, you will not get a drop-down menu with the study_id.specimen_id listed, even if a match should have been found.
  • If you type in a specimen_id, the drop-down will appear, but if it goes away for whatever reason, it can't be made to reappear unless the user retypes the id.
  • Note that in spite of the cell not turning red because a match with a study_id.specimen_id pair was found, the contents of the cell itself will not be changed to the fully-qualified version.

Likely, the list of specimen_ids for each attached study should be pulled down locally, the cell values can be matched to fully qualified study_id.specimen_id pairs locally, and the cells updated with fully qualified values. In the rare cases where a specimen_id can resolve to more than one study (more than one fully qualified pair exists), the cells can change into a new color representing ambiguity, and a pull-down menu with all pairs can be presented when the user clicks on the cell (because we can't have multiple drop-down menus appear for the case of multiple ambiguities).
@charles-cowart charles-cowart added this to the Full Launch milestone Jul 19, 2019
@charles-cowart charles-cowart self-assigned this Aug 9, 2019
@charles-cowart
Copy link
Collaborator Author

Overlap with #553

fedarko added a commit to fedarko/LabControl that referenced this issue Aug 21, 2019
@fedarko
ENH: Expose limit in StudySamplesHandler biocore#520 biocore#553
be1233f 
This is an important part of implementing client-side multi-matching
(i.e. getting all the IDs needed to perform matching).

Pair-programmed with @charles-cowart :)
fedarko added a commit to fedarko/LabControl that referenced this issue Aug 22, 2019
@fedarko
MAINT: add get_active_samples(); abstract code
e00fcd0 
get_active_samples() is based on autocomplete_search_samples(), so
I abstracted some of the code for processing responses into its own
function that can be shared.

This seems to work alright! Would really like to test this with
multiple studies, though (biocore#437).

For future reference: you can get the value of a promise returned by
get_active_samples() as follows:

get_active_samples().then(
    function(v) {
        // Now, v is the array of active sample IDs
        console.log(v);
    }
);

This is 1/3 of the work towards multi-select (just gonna tag biocore#520).

What remains are the following:
2. On a paste operation when the multi-select checkbox is checked,
   identify all "new" specimen IDs. Get an array or something of
   these, preferably. (Or we can do this on a
   specimen-ID-by-specimen-ID basis, doesn't really matter.)
3. For each new specimen ID, attempt to match it with the active
   samples. Color cells / update values accordingly based on the
   following cases:
   *   0 matches (color cell red)
   *   1 match (leave cell uncolored, and change text to matching ID)
   * >=2 matches (color cell yellow)

And ...I think that should be it, knock on wood.
fedarko added a commit to fedarko/LabControl that referenced this issue Aug 27, 2019
@fedarko
ENH: Prototype impl. of multi-select biocore#520 biocore#553
0421acb 
TODOs:

-Better then() failure handling on get_active_samples()
-Apply yellow well color (well-indeterminate CSS class IIRC) if multiple
 matches are possible.
-Remove debug console.log() stmts
@fedarko fedarko mentioned this issue Aug 30, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@fedarko fedarko

@qiyunzhu qiyunzhu

@charles-cowart charles-cowart

Labels
None yet
Projects
None yet
Milestone
Full Launch
Development

No branches or pull requests
3 participants
@fedarko @qiyunzhu @charles-cowart