Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Failing integration tests DocumentationTest #9

Open
kche309 opened this issue Jan 28, 2022 · 6 comments
Open

Failing integration tests DocumentationTest #9

kche309 opened this issue Jan 28, 2022 · 6 comments
Assignees

Comments

@kche309
Copy link
Collaborator

kche309 commented Jan 28, 2022

Building package fails beast integration test with the error below

junit_phylonco:
    [mkdir] Created dir: /home/kylie/Repos-new/beast-phylonco/build/junitreport
    [junit] Running test.beast.integration.DocumentationTest
    [junit] Tests run: 3, Failures: 2, Errors: 0, Skipped: 0, Time elapsed: 0.763 sec
    [junit] Test test.beast.integration.DocumentationTest FAILED

@kche309 to fix DocumentationTest

@kche309 kche309 self-assigned this Jan 28, 2022
@kche309 kche309 added the bug Something isn't working label Jan 28, 2022
@J-Moravec
Copy link
Member

Seems like what is being tested is BEAST2 code, not phylonco code. Integration tests might not be properly set up?
image

@kche309
Copy link
Collaborator Author

kche309 commented Feb 3, 2022

I agree, it looks like the failing classes are from BEAST2 and other packages rather than the phylonco package. It is strange it is not picked up in the beast2 github continuous integration workflow (e.g. https://github.com/CompEvol/beast2/runs/4925469365?check_suite_focus=true).

On further inspection, it seems only beast-core tests are run for BEAST2 CI

@walterxie
Copy link
Collaborator

If you did not change any Java classes, I used the Gradle to run all tests just now and they were passed:

Screen Shot 2022-02-04 at 12 51 06 PM

@J-Moravec
Copy link
Member

@walterxie This is about integration tests, not unit tests.

@kche309 kche309 removed the bug Something isn't working label Feb 22, 2022
@kche309
Copy link
Collaborator Author

kche309 commented Feb 22, 2022

Ant builds are no longer used, this is being replaced with Gradle.
Integration tests will be setup on Docker similar to https://github.com/tgvaughan/bacter

TODO: @kche309 to set up Docker file for integration tests

@kche309
Copy link
Collaborator Author

kche309 commented Feb 28, 2022

I've had a quick look into Gradle documentation, setting up integration tests looks a bit tricky https://docs.gradle.org/current/userguide/java_testing.html#sec:configuring_java_integration_tests
Beast2 does not package tests in the jar, so we can't load integration tests directly from the jar.
Probably it is easier to have a Docker + ant setup that can run and test in a clean environment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants