Skip to content

upgrade perl to v5.40.0 #35

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 5 commits into
base: perl_40
Choose a base branch
from
Open

upgrade perl to v5.40.0 #35

wants to merge 5 commits into from

Conversation

ngeojiajun-deriv
Copy link

No description provided.

review-deriv
review-deriv reviewed Jul 17, 2024
View reviewed changes
Copy link

@review-deriv review-deriv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR description is too short. You can use this format:

# Description
This is a summary of the changes. This should describe why do we need this change.
Whys and Hows come here.

# Cards
* https://clickup.com/12345
* https://clickup.com/12346

@ngeojiajun-deriv
Copy link
Author

Why changing the base image for myriad? The package should have been installed automatically during the build process

@ngeojiajun-deriv ngeojiajun-deriv changed the base branch from master to perl_40 January 13, 2025 09:56
review-deriv
review-deriv reviewed Jan 13, 2025
View reviewed changes
Copy link

@review-deriv review-deriv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR description is too short. You can use this format:

# Description
This is a summary of the changes. This should describe why do we need this change.
Whys and Hows come here.

# Cards
* https://clickup.com/12345
* https://clickup.com/12346

diego-deriv
diego-deriv reviewed Jan 14, 2025
View reviewed changes
Copy link

@diego-deriv diego-deriv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should this build both branches?

@ngeojiajun-deriv
Copy link
Author

Yes and no, we need at least the changes for perl_40 but I simply update the one for master so it is easily to reconcile the changes later

diego-deriv
diego-deriv reviewed Aug 18, 2025
View reviewed changes
diego-deriv
diego-deriv reviewed Aug 18, 2025
View reviewed changes
Dockerfile
LABEL maintainer="Deriv Services Ltd <[email protected]>"

# Some standard server-like config used everywhere
ENV TZ=UTC
ENV DEBIAN_FRONTEND=noninteractive
ENV PERL_VERSION=5.36.0
ENV PERL_SHA256=0f386dccbee8e26286404b2cca144e1005be65477979beb9b1ba272d4819bcf0
ENV PERL_VERSION=5.40.0
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

how sure are we regarding this working on the usual images depending on this, like dzil & myriad

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is tested at least on our stuffs, on the latest myriad upgrade attempt

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mukesh-deriv mukesh-deriv mukesh-deriv approved these changes

+4 more reviewers

@diego-deriv diego-deriv diego-deriv left review comments

@review-deriv review-deriv review-deriv left review comments

@nael-binary nael-binary nael-binary approved these changes

@chylli-deriv chylli-deriv chylli-deriv approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@ngeojiajun-deriv @nael-binary @chylli-deriv @diego-deriv @mukesh-deriv @review-deriv