feat(payment): PAYPAL-4935 updates after review

Author: bc-nick

packages/core/src/cart/cart-action-creator.spec.ts

@@ -28,19 +28,19 @@ describe('CartActionCreator', () => {
 
         store = createCheckoutStore(getCheckoutStoreState());
 
-        jest.spyOn(cartRequestSender, 'loadCard').mockReturnValue(
+        jest.spyOn(cartRequestSender, 'loadCart').mockReturnValue(
             Promise.resolve(getResponse(getCart())),
         );
 
         cartActionCreator = new CartActionCreator(cartRequestSender);
     });
 
     it('emits action to notify loading progress', async () => {
-        const actions = await from(cartActionCreator.loadCard(cart.id)(store))
+        const actions = await from(cartActionCreator.loadCart(cart.id)(store))
             .pipe(toArray())
             .toPromise();
 
-        expect(cartRequestSender.loadCard).toHaveBeenCalledWith(cart.id, undefined, undefined);
+        expect(cartRequestSender.loadCart).toHaveBeenCalledWith(cart.id, undefined, undefined);
 
         expect(actions).toEqual(
             expect.arrayContaining([
@@ -54,17 +54,17 @@ describe('CartActionCreator', () => {
     });
 
     it('emits error action if unable to load cart', async () => {
-        jest.spyOn(cartRequestSender, 'loadCard').mockReturnValue(
+        jest.spyOn(cartRequestSender, 'loadCart').mockReturnValue(
             Promise.reject(getErrorResponse()),
         );
 
         const errorHandler = jest.fn((action) => of(action));
 
-        const actions = await from(cartActionCreator.loadCard(cart.id)(store))
+        const actions = await from(cartActionCreator.loadCart(cart.id)(store))
             .pipe(catchError(errorHandler), toArray())
             .toPromise();
 
-        expect(cartRequestSender.loadCard).toHaveBeenCalledWith(cart.id, undefined, undefined);
+        expect(cartRequestSender.loadCart).toHaveBeenCalledWith(cart.id, undefined, undefined);
 
         expect(actions).toEqual(
             expect.arrayContaining([

packages/core/src/cart/cart-action-creator.ts

@@ -14,19 +14,19 @@ export default class CartActionCreator {
     constructor(private _cartRequestSender: CartRequestSender) {}
 
     @cachableAction
-    loadCard(
+    loadCart(
         cartId: string,
         options?: RequestOptions & ActionOptions,
     ): ThunkAction<LoadCartAction, InternalCheckoutSelectors> {
         return (store) => {
-            return Observable.create((observer: Observer<LoadCartAction>) => {
+            return new Observable((observer: Observer<LoadCartAction>) => {
                 const state = store.getState();
                 const host = state.config.getHost();
 
                 observer.next(createAction(CartActionType.LoadCartRequested, undefined));
 
                 this._cartRequestSender
-                    .loadCard(cartId, host, options)
+                    .loadCart(cartId, host, options)
                     .then((response) => {
                         observer.next(
                             createAction(CartActionType.LoadCartSucceeded, response.body),

packages/core/src/cart/cart-request-sender.spec.ts

@@ -79,7 +79,7 @@ describe('CartRequestSender', () => {
         });
     });
 
-    describe('#loadCard', () => {
+    describe('#loadCart', () => {
         const cartId = '123123';
         const host = 'https://test.com';
 
@@ -90,7 +90,7 @@ describe('CartRequestSender', () => {
         });
 
         it('get headless cart', async () => {
-            await cartRequestSender.loadCard(cartId);
+            await cartRequestSender.loadCart(cartId);
 
             expect(requestSender.get).toHaveBeenCalledWith('/cart-information', {
                 params: {
@@ -100,7 +100,7 @@ describe('CartRequestSender', () => {
         });
 
         it('get headless cart with host url', async () => {
-            await cartRequestSender.loadCard(cartId, host);
+            await cartRequestSender.loadCart(cartId, host);
 
             expect(requestSender.get).toHaveBeenCalledWith('https://test.com/cart-information', {
                 params: {

packages/core/src/cart/cart-request-sender.ts

@@ -22,7 +22,7 @@ export default class CartRequestSender {
         return this._requestSender.post(url, { body, headers, timeout });
     }
 
-    async loadCard(
+    async loadCart(
         cartId: string,
         host?: string,
         options?: RequestOptions,