Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement as prop for Button component #662

Closed
beppek opened this issue Dec 31, 2021 · 1 comment
Closed

Implement as prop for Button component #662

beppek opened this issue Dec 31, 2021 · 1 comment

Comments

@beppek
Copy link

beppek commented Dec 31, 2021

Is your feature request related to a problem? Please describe.
A common design pattern is for links to look like buttons. Currently, there's no trivial way to use button styles to render a link.

Describe the solution, feature, or improvement you'd like
Style Components provides an as prop feature which allows you to render a component as something else while preserving the styles and still render semantically correct HTML.

Describe alternatives you've considered
Currently, the only way to achieve this is to apply the same styles to the Link component.

Additional context
Since this React library can be used in several React-based frameworks with their own internal linking solutions it would be great if it wasn't tied to using this lib's Link component but would be able to handle the Link counterpart in Gatsby, Nextjs and Remix.

@beppek
Copy link
Author

beppek commented Dec 31, 2021

Sorry, just found issue 430 asking for more or less the same thing. Closing this one as duplicate.

@beppek beppek closed this as completed Dec 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

1 participant