Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upcoming changes for the next release #562

Closed
5 tasks done
Remi-Gau opened this issue May 1, 2023 · 12 comments
Closed
5 tasks done

Upcoming changes for the next release #562

Remi-Gau opened this issue May 1, 2023 · 12 comments

Comments

@Remi-Gau
Copy link
Collaborator

Remi-Gau commented May 1, 2023

The next release will happen shortly after the release of BIDS 1.9.

Planned changes

Note that the change of branches name and workflow may break some users code if they were used to checking out the dev branch rather than master.

Renaming of the default branch

Will be changed from master to main.

TODO

  • update CI branch names
  • update doc
  • changing to MIT license to be more in line with other BIDS tools in the main BIDS orga

Changes from a git-flow to a more typical CI/CD

  • dev branch will deleted.
  • bug hot fixes and new features will both be merged into main

Reason:

  • too much maintenance hassle for little benefit

TODO

  • update decision making
  • update contribution documentation

Release schedule

Minimum will be to have a new version out for each new version of the BIDS specification to allow for a support of new BIDS datatypes or features. This should at least give a "clear" answer on how to organize releases.

@Remi-Gau
Copy link
Collaborator Author

Remi-Gau commented May 1, 2023

@gllmflndn @nbeliy @ChristophePhillips @robertoostenveld @HenkMutsaerts

Pinging people who I think should know about this.

Will update the top message if there is push-back or more suggestions on this.

@nbeliy
Copy link
Collaborator

nbeliy commented May 1, 2023

If understand, the main now will be development and release branches?

As TODO, one think that could be added it's saving/loading/updating bids-matlab structure the initialization of dataset is quite slow, and it can be beneficial to initialize one and then load it from memory, but it can break the path reconstructions (depending how they are constructed). If needed, I can make a separate issue/suggestion.

@Remi-Gau
Copy link
Collaborator Author

Remi-Gau commented May 1, 2023

If understand, the main now will be development and release branches?

Yes. If you want the latest changes you just pull from main.

If you want something "stable" then you have to pull a specific tag.

If user run into a bug on a stable version then we could:

  • ask them to update to a newer version where this may have been fixed
  • try the version from main if it is fixed there but we did not cut a new release
  • we fix the bug, merge the fix in main, make a minor release (ideally)

As TODO, one think that could be added it's saving/loading/updating bids-matlab structure the initialization of dataset is quite slow, and it can be beneficial to initialize one and then load it from memory, but it can break the path reconstructions (depending how they are constructed). If needed, I can make a separate issue/suggestion.

I think this is issue #320. So we can elaborate there.

This has definitely been needed for a while though the ability to index only some subjects or sessions of a dataset can speed things up for some pipelines as you can index only those you will process.

In any case I can add this issue to the milestone for the next release but as most of the things listed there I would consider more as nice to have, if we get something together in time rather than something blocking a release.

https://github.com/bids-standard/bids-matlab/milestone/1

@Remi-Gau
Copy link
Collaborator Author

Remi-Gau commented May 1, 2023

Forgot to tag @CPernet.

If you think of anyone else please tag them.

@gllmflndn
Copy link
Collaborator

+1 on branch renaming and simpler workflow.

@CPernet
Copy link
Contributor

CPernet commented May 2, 2023

main and releases is easier to maintain than zillions of branches (although making releases it not fun) +1

@Remi-Gau Remi-Gau added this to the v0.2.0 milestone Jun 17, 2023
@Remi-Gau Remi-Gau pinned this issue Nov 14, 2023
@Remi-Gau
Copy link
Collaborator Author

Adding another change to the TODO:

  • changing to MIT license to be more in line with other BIDS tools in the main BIDS orga

@gllmflndn @CPernet @nbeliy

@Remi-Gau
Copy link
Collaborator Author

A new BIDS release is on the way for the end of the week. So I will make the changes listed in this issue after and make a new BIDS matlab release after this.

@gllmflndn
Copy link
Collaborator

👍 for the change of license from GPL to MIT.

Thank you @Remi-Gau for all the effort you've put into the upcoming release.

@CPernet
Copy link
Contributor

CPernet commented Nov 17, 2023

sure, MIT is fine - our US friends need that, thx Remi

@Remi-Gau
Copy link
Collaborator Author

Remi-Gau commented Nov 20, 2023

To rename your local master to main

git branch -m master main
git fetch origin
git branch -u origin/main main
git remote set-head origin -a

@Remi-Gau
Copy link
Collaborator Author

OK all of those are done so I am closing.

Will mop up one thing or 2 and make a github release: should be picked up and released the file exchange too
https://nl.mathworks.com/matlabcentral/fileexchange/93740-bids-matlab

@github-project-automation github-project-automation bot moved this from To do to Done in BIDS-matlab Nov 21, 2023
@Remi-Gau Remi-Gau unpinned this issue Feb 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

No branches or pull requests

4 participants