Skip to content
This repository has been archived by the owner on Mar 21, 2023. It is now read-only.

Integrate create topic #958

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

suyash-naithani
Copy link
Contributor

Things to do:

  • Remove code that is no longer needed
  • Get the available partition limit with the correct api call(Static data is used currently)

Copy link
Contributor

@riccardo-forina riccardo-forina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd try to simplify the body of the CreateTopic component. All those const could be moved out of the function. The saveTopic callback should be split in sub functions - one to convert the data, one to call the API, one to update the UI based on the API result - and moved out of the body of the function as well (but for the one that does update the UI)

@suyash-naithani
Copy link
Contributor Author

I'd try to simplify the body of the CreateTopic component. All those const could be moved out of the function. The saveTopic callback should be split in sub functions - one to convert the data, one to call the API, one to update the UI based on the API result - and moved out of the body of the function as well (but for the one that does update the UI)

Pushed some changes, let me know what you think @riccardo-forina

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants