Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ask for a name and the SA secret to use when creating a connector #15

Open
riccardo-forina opened this issue Jun 10, 2021 · 5 comments
Open
Labels

Comments

@riccardo-forina
Copy link
Contributor

In the connector creation wizard, ask the user to provide a name for the connector.

Also, ask for the SA secret the connector should use to connect to the kafka instance, or, since the SA limit has been lifted provide the option to automatically create an SA.

@riccardo-forina
Copy link
Contributor Author

I think the best place where to do ask for the name is the "Review" step. Currently, it looks like this:
image
We could add the name field above the code editor.

The SA part I'm not so sure about. Should we add a "Security" step where the user can either provide the secret or choose an automatically generated SA? And where should we put this, before the Review step? As a substep of the "Configure" step?

@jgiardino I don't think we decided anything about this. What do you think?

@indraraj
Copy link
Contributor

indraraj commented Jun 10, 2021

Just wanted to add that in DBZ we already ask for the "Connector name"(with UI side validation that it should be a Unique name).

It is being asked at the top / first step of the "Configuration" step. adding the screenshot below
image

and in the subsequent steps its shown at the top as Connector_name | Connector_type

image

@riccardo-forina
Copy link
Contributor Author

Good point, I think asking for the name makes sense in DBZ upstream but not much in MAS. Since all connectors will have a name I think this should be handled by the wizard itself.

@riccardo-forina
Copy link
Contributor Author

In #23 it has been implemented like this:

Kapture 2021-06-16 at 20 07 25

In the review step you have to provide a name and select between using an automatically created SA, or provide the client id and secret.

The automatic creation of an SA isn't yet implemented.

@jgiardino
Copy link

This is a great question! I've captured this question in our primary design document so that UX can discuss there and revisit this with a suggestion.

adding @nding-anges for awareness

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants