-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ask for a name and the SA secret to use when creating a connector #15
Comments
I think the best place where to do ask for the name is the "Review" step. Currently, it looks like this: The SA part I'm not so sure about. Should we add a "Security" step where the user can either provide the secret or choose an automatically generated SA? And where should we put this, before the Review step? As a substep of the "Configure" step? @jgiardino I don't think we decided anything about this. What do you think? |
Good point, I think asking for the name makes sense in DBZ upstream but not much in MAS. Since all connectors will have a name I think this should be handled by the wizard itself. |
In #23 it has been implemented like this: In the review step you have to provide a name and select between using an automatically created SA, or provide the client id and secret. The automatic creation of an SA isn't yet implemented. |
This is a great question! I've captured this question in our primary design document so that UX can discuss there and revisit this with a suggestion. adding @nding-anges for awareness |
In the connector creation wizard, ask the user to provide a name for the connector.
Also, ask for the SA secret the connector should use to connect to the kafka instance, or, since the SA limit has been lifted provide the option to automatically create an SA.
The text was updated successfully, but these errors were encountered: