Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow bevy_reflect and wgpu-types features in no_std for bevy_color #18061

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Allow bevy_reflect and wgpu-types features in no_std for bevy_color #18061

wants to merge 1 commit into from
+11 −6

Conversation

bushrat011899
Copy link
Contributor

Objective

  • Improve feature parity in no_std for bevy_color

Solution

  • Allowed bevy_reflect in no_std now that it has full support
  • Allowed wgpu-types in no_std now version 24 has full support
  • Added critical-section feature to make standalone usage in no_std easier

Testing

  • cargo check -p bevy_color --no-default-features --features libm,bevy_reflect,critical-section,serialize,alloc,wgpu-types --target thumbv6m-none-eabi

Notes

With these changes, bevy_color's feature support looks like this:

Feature no_std (Before) no_std (After) Notes
default ❌ ❌
std ❌ ❌
alloc ✔️ ✔️
serialize ✔️ ✔️
bevy_reflect ❌ ✔️
wgpu-types ❌ ✔️
encase ❌ ❌
libm ✔️ ✔️
critical-section ➖ ✔️

@bushrat011899 bushrat011899 added C-Feature A new feature, making something new possible D-Trivial Nice and easy! A great choice to get started with Bevy X-Uncontroversial This work is generally agreed upon S-Needs-Review Needs reviewer attention (from anyone!) to move forward A-Color Color spaces and color math O-Embedded Weird hardware and no_std platforms labels Feb 26, 2025
@alice-i-cecile alice-i-cecile added this to the 0.16 milestone Feb 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
A-Color Color spaces and color math C-Feature A new feature, making something new possible D-Trivial Nice and easy! A great choice to get started with Bevy O-Embedded Weird hardware and no_std platforms S-Needs-Review Needs reviewer attention (from anyone!) to move forward X-Uncontroversial This work is generally agreed upon
Projects
None yet
Milestone
0.16
Development

Successfully merging this pull request may close these issues.
2 participants
@bushrat011899 @alice-i-cecile