bevy_reflect: no no_std support when the functions feature is enabled
#18051
Labels
A-Reflection
Runtime information about types
C-Bug
An unexpected or incorrect behavior
D-Modest
A "normal" level of difficulty; suitable for simple features or challenging fixes
O-Embedded
Weird hardware and no_std platforms
Comments
shekohex
added
C-Bug
bushrat011899
added
A-Reflection
|
Thanks for testing this out! |
|
#18060 should solve this, but feel free to try out this branch in the mean-time! |
|
Awesome! Thank you for the quick fix. It works 🫡 |
github-merge-queue bot
pushed a commit
that referenced
this issue
Feb 27, 2025
# Objective - Fixes #18051 ## Solution - Switched function registry to use `bevy_platform_support::sync` instead of `std::sync` - Also documented that `debug_stack` (and transitively `debug`) require `std` - Also removed `std` from `wgpu-types` since that crate is now `no_std` compatible ## Testing - `cargo check -p bevy_reflect --no-default-features --features critical-section,documentation,glam,glam/libm,smallvec,wgpu-types,functions --target thumbv6m-none-eabi` --- ## Notes With these changes, `bevy_reflect`'s feature support looks like this: | Feature | `no_std` (Before) | `no_std` (After) | Notes | | - | - | - | - | | `default` | ❌ | ❌ | | | `std` | ❌ | ❌ | | | `documentation` | ✔️ | ✔️ | | | `functions` | ❌ | ✔️ | | | `critical-section` | ✔️ | ✔️ | | | `bevy` | ✔️* | ✔️* | Partial due to `smol_str` | | `debug` | ❌ | ❌ | | | `debug_stack` | ❌ | ❌ | | | `petgraph` | ❌ | ❌ | | | `glam` | ✔️* | ✔️* | Requires enabling `glam/libm` | | `smallvec` | ✔️ | ✔️ | | | `uuid` | ✔️* | ✔️* | Requires setting up `getrandom` backend | | `wgpu-types ` | ❌ | ✔️ | | | `smol_str` | ✔️* | ✔️* | Partial due to `smol_str` not supporting `portable-atomic` |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Bevy version
The release number or commit hash of the version you're using.
Bevy main
11db717What you did
I'm trying to use
bevy_reflectin a project and this project requiresno_stdsupport. the latestbevy_reflectreleasev0.15.3hasno_stdsupport, but not really, since the#[derive(Reflect)]uses::std::boxed::Box<..>in the trait implementation.After some search and looking for the code on github, I found that it actually now supports
no_std, However, enabling thefunctionsfeature makes it not compiling withoutstdfeature enabled as it still usesstdhere:bevy/crates/bevy_reflect/src/func/registry.rs
Line 5 in 11db717
What went wrong
bevy_reflecthasno_stdsupport.funcmodule does not fully work whenstdfeature is disabled.The text was updated successfully, but these errors were encountered: