Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unifiy cluster and clusterArn parameters #10

Open
dmarvp opened this issue Apr 24, 2020 · 0 comments
Open

Unifiy cluster and clusterArn parameters #10

dmarvp opened this issue Apr 24, 2020 · 0 comments
Labels
upcoming

Comments

@dmarvp
Copy link
Collaborator

dmarvp commented Apr 24, 2020

Description

Inside our code we have two parameters related to selecting a cluster
cluster which can be the cluster short name OR the full ARN
clusterArn which can is needed for scheduled tasks and can only be an ARN

We should keep just one for simplicity and clarity of the code.

###Steps

  1. Replace all the occurrences of Config.str("cluster") with Config.str("clusterArn")
  2. Remove cluster from the readme
  3. Remove cluster from the fargate-helper secret in Secrets Manager
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
upcoming
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@dmarvp