Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Restart_instance in sumo_params should be true for inflows #39

Open
eugenevinitsky opened this issue Aug 15, 2018 · 1 comment
Open

Restart_instance in sumo_params should be true for inflows #39

eugenevinitsky opened this issue Aug 15, 2018 · 1 comment
Labels
feature request

Comments

@eugenevinitsky
Copy link
Collaborator

In sumo_params, restart_instance defaults to false. However, if you have inflows, this causes it to progressively slow down. If we have inflows, it should be defaulting to True.
@AboudyKreidieh
Copy link
Collaborator

If we force restart_instance to be true, then they will not be able to run simulations with resets without the windows constantly opening and closing. We could recommend in the docstring when to sit it to true and when to set it to false, or alternatively have them deal with constantly pressing run inbetween rollouts. Thoughts?

kjang96 pushed a commit to kjang96/flow that referenced this issue Aug 17, 2018
@AboudyKreidieh
Merge pull request berkeleyflow#39 from berkeleyflow/port_fix2
7fe4c9c 
Port fix2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@eugenevinitsky @AboudyKreidieh