Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

musicbrainz ID #23

Open
eriwst opened this issue Sep 30, 2020 · 4 comments · May be fixed by #27
Open

musicbrainz ID #23

eriwst opened this issue Sep 30, 2020 · 4 comments · May be fixed by #27

Comments

@eriwst
Copy link

eriwst commented Sep 30, 2020

Hi,

is it possible to also fetch the tracks musicbrainz id?

@luiseduardobrito
Copy link

luiseduardobrito commented Sep 19, 2021

This is extremely useful, specially for deduplication during import/export routines from different applications.

I got this working in a fork, getting all available MBIDs already present in the response data (track, artist and album) so no additional requests are made. I also added the CSV headers so it would not cause any confusion around the different mbid attributes I'm trying to fetch.

image

The code needs some polishing before a proper PR, and all changes should be optional and disabled by default, so we won't break anyone using this regularly. I've published the fork in a Gitlab Page temporarily for testing.

@benfoxall
Copy link
Owner

Oh, fantastic!!

@luiseduardobrito, would you be able to raise a PR? It'd be great to get those changes in. I'd be happy to help with code polishing if you PR what you've got already.

Maybe these checkboxes might work better in the settings dialog?

image

@luiseduardobrito luiseduardobrito linked a pull request Oct 2, 2021 that will close this issue
@luiseduardobrito
Copy link

luiseduardobrito commented Oct 2, 2021

@benfoxall I've moved them to the modal and done some code polishing, there's some vertical alignment issue but I think it's good enough for a PR, I'm not too worried about how it looks :)

image

Feel free to change it as you see fit.

@benfoxall
Copy link
Owner

@luiseduardobrito, this is awesome! Thank you so much. Looking through your PR now 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants