Skip to content

pr.md

Latest commit

 

History

History
54 lines (38 loc) · 2.77 KB

pr.md

File metadata and controls

54 lines (38 loc) · 2.77 KB
Raw

Summary

This PR implements a comprehensive suite of landlord management features, replacing static mock data with live backend integration. It includes a new database schema for landlord profiles, authenticated API endpoints for tenant rosters and settings management, and fully interactive frontend dashboards for profile, notification, and payout configuration.

Linked issue (recommended)

Closes #590, Closes #591, Closes #592, Closes #593

Changes

Backend Infrastructure

  • [New Migration] backend/migrations/010_landlord_profiles.sql: Added tables for landlord settings, phone, company details, and bank information.
  • [AuthRepository]: Added LandlordProfile interface and methods to getLandlordProfile and updateLandlordProfile.
  • [AuthStore]: Exposed landlord profile management through UserStore.
  • [New Router] backend/src/routes/landlord.ts: Implemented GET /tenants, GET /settings, and PATCH /settings endpoints.
  • [App Entry] backend/src/app.ts: Registered the landlord router under /api/landlord.

Frontend Dashboards

  • [Tenants Roster] frontend/app/dashboard/landlord/tenants/page.tsx: Replaced mock data with live apiFetch integration; added NGN currency and date formatting.
  • [Settings Flow] frontend/app/dashboard/landlord/settings/page.tsx: Implemented full state management for Profile, Notifications, and Payout tabs with real-time API syncing.

Implementation Details

This is not a SOROBAN contract update. This PR focuses on full-stack features for landlord management.

How to test

  • All automated tests pass
  • Integration tests pass (if applicable)
  • Manual testing completed:
    • Verified tenant roster displays correct property and lease data from the database.
    • Verified profile, notification preferences, and bank details persist correctly across page reloads.
    • Verified role-based authentication prevents unauthorized access to landlord endpoints.

Security Considerations

  • No secrets or sensitive data are logged
  • No changes to authentication/authorization logic without review (uses existing authenticateToken middleware)
  • No changes to admin/upgrade logic without review

Screenshots (if UI)

Refer to the walkthrough.md for detailed UI screenshots and state transitions (loading/success).

Checklist

  • I linked an issue (or explained why one is not needed)
  • I tested locally
  • I did not commit secrets
  • I updated docs if needed
  • Code follows the project's style guidelines
  • CI checks pass
  • If UI changes: I included before/after screenshots (via walkthrough)
  • If images added/changed: I verified they are optimized and accessible