Review feedback: floating point precision in test, ensure unsigned int handling in Robot

Author: beldenfox

modules/javafx.graphics/src/main/native-glass/mac/GlassRobot.m

@@ -412,15 +412,15 @@ - (void)mouseRelease:(UInt32)buttons
                 CFDataRef data = CGDataProviderCopyData(provider);
                 if (data != NULL)
                 {
-                    jint *pixels = (jint*)CFDataGetBytePtr(data);
+                    uint32_t *pixels = (uint32_t*)CFDataGetBytePtr(data);
                     if (pixels != NULL)
                     {
-                        color = *pixels;
+                        uint32_t pixel = *pixels;
                         CGFloat components[4];
-                        components[0] = (CGFloat)((color & 0x00FF0000) >> 16) / 255.0;
-                        components[1] = (CGFloat)((color & 0x0000FF00) >> 8) / 255.0;
-                        components[2] = (CGFloat)((color & 0x000000FF)) / 255.0;
-                        components[3] = (CGFloat)((color & 0xFF000000) >> 24) / 255.0;
+                        components[0] = (CGFloat)((pixel & 0x00FF0000) >> 16) / 255.0;
+                        components[1] = (CGFloat)((pixel & 0x0000FF00) >> 8) / 255.0;
+                        components[2] = (CGFloat)((pixel & 0x000000FF)) / 255.0;
+                        components[3] = (CGFloat)((pixel & 0xFF000000) >> 24) / 255.0;
                         origColor = CGColorCreate(CGImageGetColorSpace(screenImage), components);
                     }
                 }

tests/system/src/test/java/test/robot/javafx/scene/SRGBTest.java

@@ -64,8 +64,9 @@ public class SRGBTest extends VisualTestBase {
     static final float HIGH = 0.75f;
 
     // The component tolerance allows one bit of rounding when writing a color
-    // out and another bit when reading it back in.
-    static final double COMPONENT_TOLERANCE = 2.0 / 255.0;
+    // out and another bit when reading it back in. The additional 0.0001
+    // accounts for floating point precision limitations.
+    static final double COMPONENT_TOLERANCE = 2.0001 / 255.0;
 
     private enum TestColor {
         COLOR_01(LOW, MID, HIGH),