Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dialogs customization #3027

Open
PrakashFilippoBasso opened this issue Dec 8, 2024 · 2 comments
Open

Dialogs customization #3027

PrakashFilippoBasso opened this issue Dec 8, 2024 · 2 comments
Labels
enhancement New features, or improvements to existing features.

Comments

@PrakashFilippoBasso
Copy link

What is the problem or limitation you are having?

I need a second custom button in a Dialog, for example, in "About" I may need the "Okay", but also the "Copy" button, so that I can easily copy some version-related infos in a simple way... Or, anyway, it's normal to have buttons in Dialogues, more than one, with custom labels/actions.

Describe the solution you'd like

make a Custom Dialog, where you can add buttons with labels and actions

Describe alternatives you've considered

creating a window...? not so clean

Additional context

No response

@PrakashFilippoBasso PrakashFilippoBasso added the enhancement New features, or improvements to existing features. label Dec 8, 2024
@HalfWhitt
Copy link
Contributor

Related:

@freakboy3742
Copy link
Member

Thanks for the suggestion. Regarding the specific use case you've described, it's worth noting that an About dialog isn't "just a dialog" - platforms have specialised subclasses for managing "About" content.

Even "normal" dialogs have very specific platform guidelines for how options should be displayed. In addition, the UX guidelines for most platforms advise away from the use of dialogs as a UI mechanism, as they are "blocking" behaviors. I don't know the specifics of your case, but it may be worth interrogating whether a dialog (and the About dialog specifically) is the right solution.

That said - while Toga should aim to provide good "out of the box" solutions for common use cases, there will always be edge cases, so an API for completely custom dialogs is a use case we should allow. Toga's own StackTraceDialog can likely serve as a the starting point of an implementation - StackTraceDialog is effectively a custom dialog, but without the "custom" part (the panel of content and the button choices) being exposed as public API.

@mhsmith mhsmith changed the title Dialogs Dialogs customization Dec 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New features, or improvements to existing features.
Projects
None yet
Development

No branches or pull requests

3 participants