Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ask user if the app is a console app during conversion #1900

Open
rmartin16 opened this issue Jul 7, 2024 · 1 comment
Open

Ask user if the app is a console app during conversion #1900

rmartin16 opened this issue Jul 7, 2024 · 1 comment
Labels
enhancement New features, or improvements to existing features. good first issue Is this your first time contributing? This could be a good place to start!

Comments

@rmartin16
Copy link
Member

rmartin16 commented Jul 7, 2024

What is the problem or limitation you are having?

Before I really understood the "console app" settings, I was a bit confused when my app wouldn't run following conversion. I finally realized that console apps require the console_app = true key to control stdout properly. After adding that setting, my app started working.

Describe the solution you'd like

During the conversion process, ask the user if the existing app is a console app and configure pyproject.toml appropriately.

Describe alternatives you've considered

Manually add the console app settings.

Additional context

No response

@rmartin16 rmartin16 added the enhancement New features, or improvements to existing features. label Jul 7, 2024
@freakboy3742
Copy link
Member

Makes sense - it's a step that is implied when you pick a GUI framework, but conversion of an existing project needs that extra context.

It should be relatively straightforward to add an extra question during the convert command, mirroring the location in the wizard where you'd ask for the GUI framework.

@freakboy3742 freakboy3742 added the good first issue Is this your first time contributing? This could be a good place to start! label Jul 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New features, or improvements to existing features. good first issue Is this your first time contributing? This could be a good place to start!
Projects
None yet
Development

No branches or pull requests

2 participants