Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reimport files: old folder won't get deleted always #1772

Closed
ghost opened this issue Dec 24, 2015 · 6 comments
Closed

reimport files: old folder won't get deleted always #1772

ghost opened this issue Dec 24, 2015 · 6 comments
Labels
needinfo We need more details or follow-up from the filer before this can be tagged "bug" or "feature."

Comments

@ghost
Copy link

ghost commented Dec 24, 2015

I've some files in my lib accidentally imported as Albums, I'm going to reimport now as single tracks. I'm using beet import -As foo/ as I dont need to autotag again and want to reimport them as singletons. Also I've set up beets to move files. Now when I'm reimporting tracks this way, the old folder won't get deleted. This happens only to folders with a cover art image in there. I would prefer to keep the cover and go with the moved files within the non-albums folder.

I think I imported the files first as (fake) albums as I wanted to have at least a cover art fetched and embedded with, even if it isnt the right one. I dont know if this makes sense on singleton tracks.

@sampsyo sampsyo added the needinfo We need more details or follow-up from the filer before this can be tagged "bug" or "feature." label Dec 24, 2015
@sampsyo
Copy link
Member

sampsyo commented Dec 24, 2015

The trouble, I think, is that singletons (non-album tracks) can't have associated album art files. You might consider embedding the image into the tracks and then deleting the original image file if that's what you need. Does that make sense?

@ghost
Copy link
Author

ghost commented Dec 24, 2015

Yes, I thought about the same. But still isn't solving the issue with the empty folders left behind. The same happens if I import single tracks from a folder, after all files moved to my lib, the folder is still there (empty).

@sampsyo
Copy link
Member

sampsyo commented Dec 24, 2015

Well, in that case, I think this is an instance of #130. Namely, we don't prune the top-level directory given on the command line (or anything above it), because this can be surprising for users when they import a "Music" container and don't want it to disappear. Does this sound like what's going on?

@ghost
Copy link
Author

ghost commented Dec 24, 2015

Yes, but what about the folder with cover.jpg left behind on moving? 😿
This wouldn't be the expected behaviour with fetchart plugin.

@sampsyo
Copy link
Member

sampsyo commented Dec 25, 2015

The fetchart plugin doesn't run on singleton imports, so the image doesn't go anywhere. Does that explain it?

@sampsyo
Copy link
Member

sampsyo commented Jan 26, 2016

Timing out. Please reopen if things aren't clear.

@sampsyo sampsyo closed this as completed Jan 26, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needinfo We need more details or follow-up from the filer before this can be tagged "bug" or "feature."
Projects
None yet
Development

No branches or pull requests

1 participant