Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Newly imported directory not removed #1144

Closed
djl opened this issue Dec 14, 2014 · 1 comment
Closed

Newly imported directory not removed #1144

djl opened this issue Dec 14, 2014 · 1 comment

Comments

@djl
Copy link
Member

djl commented Dec 14, 2014

I think I'm running into a bug with the clutter feature, where the directory being imported is not deleted despite only containing "clutter" files. Here's an example:

$ ls /tmp/music
cover.jpg
music.m3u
music.srr
01-foo.flac
02-bar.flac
03-baz.flac

$ beet import /tmp/music
...

$ ls /tmp/music
cover.jpg
music.m3u
music.srr

And my configuration:

clutter:
  - 'Thumbs.db'
  - '.DS_Store'
  - '*.log'
  - '*.txt'
  - '*.cue'
  - '*.m3u'
  - '*.srr'

After the import, /tmp/music only contains files from my clutter but it hasn't been removed.

Is this a bug or am I misunderstanding how this feature works?

@sampsyo
Copy link
Member

sampsyo commented Dec 14, 2014

I believe you're running into #130. We don't prune the top-level directory that's the argument to import under the assumption that this could surprise users; instead, we only prune the recursively-searched subdirectories. As the (old) thread on that ticket indicates, I don't know what a good solution to this is—changing the behavior could make the other 50% of users unhappy. 😃 Suggestions welcome.

@sampsyo sampsyo closed this as completed Dec 14, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants