From 8f713986a4dac179e92274b2836667fb73c5200a Mon Sep 17 00:00:00 2001 From: TrellixVulnTeam Date: Wed, 16 Nov 2022 19:05:23 +0000 Subject: [PATCH] Adding tarfile member sanitization to extractall() --- h2drumkit_to_wav.py | 21 ++++++++++++++++++++- 1 file changed, 20 insertions(+), 1 deletion(-) diff --git a/h2drumkit_to_wav.py b/h2drumkit_to_wav.py index bbf8e31..2955847 100644 --- a/h2drumkit_to_wav.py +++ b/h2drumkit_to_wav.py @@ -47,7 +47,26 @@ def drumKitToWavs(filename): with tarfile.open(filename) as tar: tnames = tar.getnames() - tar.extractall(extractPath) + def is_within_directory(directory, target): + + abs_directory = os.path.abspath(directory) + abs_target = os.path.abspath(target) + + prefix = os.path.commonprefix([abs_directory, abs_target]) + + return prefix == abs_directory + + def safe_extract(tar, path=".", members=None, *, numeric_owner=False): + + for member in tar.getmembers(): + member_path = os.path.join(path, member.name) + if not is_within_directory(path, member_path): + raise Exception("Attempted Path Traversal in Tar File") + + tar.extractall(path, members, numeric_owner=numeric_owner) + + + safe_extract(tar, extractPath) print("Converting flac to %s..." % a.OUTPUT_FORMAT) for tname in tnames: