Fix error in thumbnail retrieval (#1236)

* fix: require bedita web-tools 5.3.3

* tests: fix

* chore fix: phpcs and stan

Author: didoda

composer.json

@@ -23,7 +23,7 @@
     "require": {
         "php": ">=8.3",
         "bedita/i18n": "^5.1.0",
-        "bedita/web-tools": "^5.3",
+        "bedita/web-tools": "^5.3.3",
         "cakephp/authentication": "^2.9",
         "cakephp/cakephp": "~4.5.0",
         "cakephp/plugin-installer": "^1.3",

tests/TestCase/Controller/ModulesControllerTest.php

@@ -21,6 +21,8 @@
 use Authentication\AuthenticationServiceInterface;
 use Authentication\Identity;
 use Authentication\IdentityInterface;
+use BEdita\SDK\BEditaClient;
+use BEdita\SDK\BEditaClientException;
 use Cake\Cache\Cache;
 use Cake\Core\Configure;
 use Cake\Event\Event;
@@ -763,14 +765,21 @@ public function testDeleteError(): void
                 'REQUEST_METHOD' => 'POST',
             ],
             'post' => [
-                'wrongquery' => '123456789',
+                'id' => '123456789',
             ],
             'params' => [
                 'object_type' => 'documents',
             ],
         ];
         $request = new ServerRequest($config);
         $this->controller = new ModulesControllerSample($request);
+        $apiClient = new class ('https://api.example.com') extends BEditaClient {
+            public function delete(string $path, ?string $body = null, ?array $headers = null): ?array
+            {
+                throw new BEditaClientException('Error');
+            }
+        };
+        $this->controller->setApiClient($apiClient);
 
         // do controller call
         $result = $this->controller->delete();

tests/Utils/ModulesControllerSample.php

@@ -32,7 +32,7 @@ public function availableRelationshipsUrl(string $relation): string
     }
 
     /**
-     * Create new object from ajax request.
+     * Get api client.
      *
      * @return \BEdita\SDK\BEditaClient
      */
@@ -41,6 +41,17 @@ public function getApiClient(): BEditaClient
         return $this->apiClient;
     }
 
+    /**
+     * Set api client.
+     *
+     * @param \BEdita\SDK\BEditaClient|null $client Api client.
+     * @return void
+     */
+    public function setApiClient(?BEditaClient $client = null): void
+    {
+        $this->apiClient = $client;
+    }
+
     /**
      * Create new object from ajax request.
      *