Skip to content

Commit d6f5c0e

Browse files
committed
fix(launch_window): added one more connection for BECStatusBroker to show launcher
1 parent 5514666 commit d6f5c0e

2 files changed

Lines changed: 8 additions & 8 deletions

File tree

bec_widgets/applications/launch_window.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -549,7 +549,7 @@ def _launcher_is_last_widget(self, connections: dict) -> bool:
549549
remaining_connections = [
550550
connection for connection in connections.values() if connection.parent_id != self.gui_id
551551
]
552-
return len(remaining_connections) <= 4
552+
return len(remaining_connections) <= 5
553553

554554
def _turn_off_the_lights(self, connections: dict):
555555
"""

tests/end-2-end/test_rpc_widgets_e2e.py

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -78,15 +78,15 @@ def test_available_widgets(qtbot, connected_client_gui_obj):
7878
"""This test checks that all widgets that are available via gui.available_widgets can be created and removed."""
7979
gui = connected_client_gui_obj
8080
dock_area = gui.bec
81-
# Number of top level widgets, should be 4
82-
top_level_widgets_count = 12
81+
# Number of top level widgets, should be 5
82+
top_level_widgets_count = 13
8383
assert len(gui._server_registry) == top_level_widgets_count
8484
names = set(list(gui._server_registry.keys()))
85-
# Number of widgets with parent_id == None, should be 2
85+
# Number of widgets with parent_id == None, should be 3
8686
widgets = [
8787
widget for widget in gui._server_registry.values() if widget["config"]["parent_id"] is None
8888
]
89-
assert len(widgets) == 2
89+
assert len(widgets) == 3
9090

9191
# Test all relevant widgets
9292
for object_name in gui.available_widgets.__dict__:
@@ -122,7 +122,7 @@ def test_available_widgets(qtbot, connected_client_gui_obj):
122122
for widget in gui._server_registry.values()
123123
if widget["config"]["parent_id"] is None
124124
]
125-
assert len(widgets) == 2
125+
assert len(widgets) == 3
126126

127127
#############################
128128
####### Remove widget #######
@@ -154,10 +154,10 @@ def test_available_widgets(qtbot, connected_client_gui_obj):
154154
f"is {len(gui._server_registry)} instead of {top_level_widgets_count}. The following "
155155
f"widgets are not cleaned up: {set(gui._server_registry.keys()) - names}"
156156
) from exc
157-
# Number of widgets with parent_id == None, should be 2
157+
# Number of widgets with parent_id == None, should be 3
158158
widgets = [
159159
widget
160160
for widget in gui._server_registry.values()
161161
if widget["config"]["parent_id"] is None
162162
]
163-
assert len(widgets) == 2
163+
assert len(widgets) == 3

0 commit comments

Comments
 (0)