feat(scilog): add support for file dimensions in ingest_data method

Author: wakonig

backend/bec_atlas/ingestor/scilog_logbook_manager.py

@@ -190,7 +190,12 @@ def ingest_data(self, msg: messages.MessagingServiceMessage, logbook_id: str):
                 with open(file_path, "wb") as f:
                     f.write(msg_part.data)
                 files.append(file_path)
-                scilog_msg.add_file(file_path)
+                dimensions = {}
+                if msg_part.width is not None:
+                    dimensions["width"] = msg_part.width
+                if msg_part.height is not None:
+                    dimensions["height"] = msg_part.height
+                scilog_msg.add_file(file_path, **dimensions)
             elif isinstance(msg_part, messages.MessagingServiceTagsContent):
                 scilog_msg.add_tag(msg_part.tags)
 

backend/pyproject.toml

@@ -16,7 +16,7 @@ dependencies = [
     "fastapi[standard]",
     "pyjwt",
     "pwdlib[argon2]",
-    "bec_lib",
+    "bec_lib~=3.112",
     "python-socketio[asyncio_client]",
     "libtmux",
     "websocket-client",
@@ -25,7 +25,7 @@ dependencies = [
     "ldap3",
     "typer",
     "requests",
-    "scilog~=2.1",
+    "scilog~=2.3",
 ]
 
 

backend/tests/test_scilog_logbook_manager.py

@@ -574,3 +574,42 @@ def test_ingest_data_file_cleanup_on_error(logbook_manager, mock_scilog, sample_
         # Despite the error, directory should exist (failed to clean up the file)
         # In this case we expect subdirectories to remain since file removal failed
         assert len(list(tmp_path.iterdir())) > 0
+
+
+@pytest.mark.timeout(60)
+@pytest.mark.parametrize(
+    "width,height",
+    [(800, 600), (None, 600), (800, None), (None, None), ("800px", "600px"), ("50%", "50%")],
+)
+def test_ingest_data_file_with_dimensions(
+    logbook_manager, mock_scilog, sample_logbook, tmp_path, width, height
+):
+    """Test ingesting a file with dimensions (width and height)."""
+    mock_scilog.get_logbooks.return_value = [sample_logbook]
+    mock_message = mock.Mock()
+    mock_scilog.new.return_value = mock_message
+
+    file_data = b"Test image content"
+    msg = messages.MessagingServiceMessage(
+        service_name="scilog",
+        message=[
+            messages.MessagingServiceFileContent(
+                filename="image.png",
+                data=file_data,
+                mime_type="image/png",
+                width=width,
+                height=height,
+            )
+        ],
+        scope="deployment_scope",
+    )
+
+    logbook_manager.ingest_data(msg, "logbook_123")
+
+    # Verify add_file was called with dimensions
+    assert mock_message.add_file.call_count == 1
+    args, kwargs = mock_message.add_file.call_args
+    if width is not None:
+        assert "width" in kwargs and kwargs["width"] == width
+    if height is not None:
+        assert "height" in kwargs and kwargs["height"] == height