Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make BackgroundActionQueue catch exceptions #197

Open
paulcscharf opened this issue Oct 14, 2020 · 0 comments
Open

Make BackgroundActionQueue catch exceptions #197

paulcscharf opened this issue Oct 14, 2020 · 0 comments
Labels
enhancement good-first-issue Great issue to start out with if you're new to the code base and would like to help. hacktoberfest Good issues to contribute as part of Hacktoberfest

Comments

@paulcscharf
Copy link
Member

paulcscharf commented Oct 14, 2020

🆙 Improvement proposal

At present, the BackgroundActionQueue will break if any actions executed throw. While the user can catch and handle their own exception, we should consider doing this for them, and offering various methods of getting at those errors (like the Result monad).

Context

Exceptions and threads are a real pain. Best to make that interface as easy as possible and prevent things from blowing up in a user's face.

EDIT: ManualActionQueue has the same problem. Also worth noting is that calls to RunAndAwait will never return if the action throws, which is even worse than the queue breaking.

@paulcscharf paulcscharf added the good-first-issue Great issue to start out with if you're new to the code base and would like to help. label Oct 19, 2020
@tomrijnbeek tomrijnbeek added the hacktoberfest Good issues to contribute as part of Hacktoberfest label Sep 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement good-first-issue Great issue to start out with if you're new to the code base and would like to help. hacktoberfest Good issues to contribute as part of Hacktoberfest
Projects
None yet
Development

No branches or pull requests

2 participants