Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stripe API Version table in README is years outdated #831

Open
2 tasks done
happycappie opened this issue Mar 15, 2024 · 7 comments
Open
2 tasks done

Stripe API Version table in README is years outdated #831

happycappie opened this issue Mar 15, 2024 · 7 comments

Comments

@happycappie
Copy link

Existing Issue or Pull Request Verification

  • Confirmed, no existing Issues or Pull Requests found related to my submission.

Package Version

3.1.1

Are you using the latest version?

  • Yes, I verified the issue is still present in the latest version.

Steps to Reproduce

Compare the table in Which version should I use to the list at Stripe API versions.

Expected Result

Mapping of :stripity_stripe versions to Stripe API versions after 2019-10-17:

  • 2023-10-16
  • 2023-08-16
  • 2022-11-15
  • 2022-08-01
  • 2020-08-27
  • 2020-03-02
  • 2019-12-03
  • 2019-11-05

Actual Result

image

@yordis
Copy link
Member

yordis commented Mar 15, 2024

the generator stopped working #829

We need some consensus in terms of what I should do to fix it!

Copy link

This issue has been automatically marked as "stale:discard". If this issue still relevant, please leave any comment (for example, "bump"), and we'll keep it open. We are sorry that we haven't been able to prioritize it yet. If you have any new additional information, please include it with your comment.

@PJUllrich
Copy link
Contributor

PJUllrich commented Apr 22, 2024

The OpenAPI spec you use for code generation has the latest API version in info -> version. Could you maybe update the Readme with it?

I see it in spec3.json -> "info" -> "version"
CleanShot 2024-04-22 at 11 18 15@2x

Copy link

This issue has been automatically marked as "stale:discard". If this issue still relevant, please leave any comment (for example, "bump"), and we'll keep it open. We are sorry that we haven't been able to prioritize it yet. If you have any new additional information, please include it with your comment.

@happycappie
Copy link
Author

bump, please see comment above from #831 (comment)

@yordis
Copy link
Member

yordis commented May 23, 2024

Related to #829

@sygour
Copy link

sygour commented Sep 19, 2024

Hello,

I wanted to update the lib to the latest version but hit the same issue.
Then I found that in the source, the version is already available:

Can we rely on this version?

If so, could we at least add it to the README as a workaround?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants