Title: Changes needed to automated flagging of CA
Description:
Wireframe:
Purpose and benefit to user: The purpose is to allow IDIR users more flexibiltiy when reviewing and recommending CA as part of a MYR report.
Acceptance Criteria:
Development Checklist:
Notes:
Discussion notes:
this is what happened: the MYR was returned to the supplier on Nov.13, and then resubmitted to government on Nov.25. This means that the MYR had a status of "DRAFT" during this time. The CA was recommended to the director on Nov.21, and since the MYR had a status of "DRAFT", the "Issue credit application backdated to Sept. 30 as part of their Model Year Report" checkbox didn't appear on the CA page when it was recommended. Since that checkbox didn't appear, it wasn't checked, and that's why the CA was not flagged as part of a MYR.
Note: A model year report is considered to be in a "returned to supplier" state if its status is "DRAFT" and if it has a history entry of "SUBMITTED." The relevant parts in the code: the fetchReports function in frontend/src/credits/components/CreditRequestDetailsPage.js, and the get_queryset function in backend/api/viewsets/model_year_report.py. Whoever works on this may want to just create a new endpoint that returns "returned to supplier" reports and call that endpoint in fetch_reports.
Title: Changes needed to automated flagging of CA
Description:
Wireframe:
Purpose and benefit to user: The purpose is to allow IDIR users more flexibiltiy when reviewing and recommending CA as part of a MYR report.
Acceptance Criteria:
Development Checklist:
Notes:
Discussion notes:
this is what happened: the MYR was returned to the supplier on Nov.13, and then resubmitted to government on Nov.25. This means that the MYR had a status of "DRAFT" during this time. The CA was recommended to the director on Nov.21, and since the MYR had a status of "DRAFT", the "Issue credit application backdated to Sept. 30 as part of their Model Year Report" checkbox didn't appear on the CA page when it was recommended. Since that checkbox didn't appear, it wasn't checked, and that's why the CA was not flagged as part of a MYR.
Note: A model year report is considered to be in a "returned to supplier" state if its status is "DRAFT" and if it has a history entry of "SUBMITTED." The relevant parts in the code: the
fetchReportsfunction infrontend/src/credits/components/CreditRequestDetailsPage.js, and theget_querysetfunction inbackend/api/viewsets/model_year_report.py. Whoever works on this may want to just create a new endpoint that returns "returned to supplier" reports and call that endpoint infetch_reports.