BUG: Editing user access request

[zoeyli-46]

Describe the Bug:

Editing a user access request does not save, and stays in "pending"

Probability:

5: Happens every time, including after refreshing the page
(How likely the bug is to happen, scored from 1-5. For example, probability of 5 is something like "it happens to all users every time they log in." whereas probability of 1 "only happens to certain users when a really specific and unlikely path is followed.")

Impact:

3: bug causes the edit to not be saved
(How bad the bug is when it does happen, scored from 1-5. For example, effect of 5 is "the entire app crashes and makes it unusable for all users" or "the bug causes the wrong data to be saved, with critical information (e.g. payment) being affected." whereas effect of 1 is "It makes some styling look a little bit weird.")

Steps to reproduce the behaviour:

1. Go to user access grid
2. Click edit on a user that was "approved"
3. Click "approve"
4. Status and action column is now blank instead of "approved" and "edit"
5. Refreshing the page makes the status go back to "pending" and the actions "approve/decline" instead of saving the changes

Screenshots:

Refreshing the page reverts back to edit mode instead of showing the saved changes

Additional information:

OS: macOS monterey
Browser: Chrome
Version: 12.2.1

Additional Context

[zoeyli-46]

@patriciarussellCAS @fviduya I found a bug where editing a user access request goes blank and doesn't save the edit. I didn't see an existing ticket for this so I made one!

[fviduya]

Thanks @zoeyli-46! I checked the backend pod and it's giving error 500 and this is what I'm seeing in the backend pod too:

Logger: Exception sending operator access request email - permission denied for table email_notification

From the teams channel: Looks like it's gonna get fixed in this PR #2952

[fviduya]

I have tested this in the DEV environment, here is the test document for reference.

I can verify that:

• When a user's access request for the Reporter role is approved, Status = Approved, User Role = Reporter, and Actions column has Edit button
• When a user's access request for the Admin role is approved, Status = Approved, User Role = Admin, and Actions column has Edit button
• When a user's access request for the Reporter role is declined, Status = Declined, User Role = N/A, and Actions column has Edit button
• When a user's access request for the Admin role is declined, Status = Declined, User Role = N/A, and Actions column has Edit button
• When a user's access request has not been approved or denied, User Role dropdown has two options: Reporter and Admin

Additional check:

• When a user's access request is approved, a contact is created for that user

Multiple contact records are still being created when approving a user access request multiple times, this is logged already in #2784. Moving to Pending PO for review of test and notes. Thank you!

[patriciarussellCAS]

Moving to accepted. thanks!