Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade project to newer ACA-Py version #766

Closed
esune opened this issue Feb 8, 2024 · 16 comments
Closed

Upgrade project to newer ACA-Py version #766

esune opened this issue Feb 8, 2024 · 16 comments
Assignees

Comments

@esune
Copy link
Member

esune commented Feb 8, 2024

aries-vcr (and related projects) is still using ACA-Py 0.7.1 and should be updated to use a more recent version of the agent.

This will require some regression testing work to ensure that breaking changes will not be affecting functionality, as well as updating the issuer_registration plugin to be compatible with the newer agent version (and handle gracefully breaking changes).

@WadeBarnes
Copy link
Member

WadeBarnes commented Feb 9, 2024

Refer to bcgov/DITP-DevOps#18 and bcgov/orgbook-configurations#124 for details and links regarding the issues that have been identified.

@WadeBarnes
Copy link
Member

WadeBarnes commented May 22, 2024

Specific blocking issue can be found starting here; bcgov/orgbook-configurations#124 (comment)

Newer versions of ACA-Py don't work well with Aries-VCR and/or BC Registries Agent.

@WadeBarnes
Copy link
Member

WadeBarnes commented May 22, 2024

Is this something we can look into while there is active development going on? I'd like be able to upgrade OrgBook and BC Reg to ghcr.io/hyperledger/aries-cloudagent-python:py3.9-indy-1.16.0-0.12.1

cc @esune, @ianco

@ianco
Copy link
Contributor

ianco commented May 22, 2024

Do we want to update OrgBook to support the V2 endpoints as part of this update? (We need to leave V1 support in place obvs)

@WadeBarnes
Copy link
Member

@esune?

@ianco
Copy link
Contributor

ianco commented May 22, 2024

FYI did a quick test - with an update to the aca-py version the BC Reg issuer is still able to register on startup (i.e. the issuer registration plug-in is working with an updated aca-py) but credential issuing is failing. Not sure why looking into it ...

@WadeBarnes
Copy link
Member

FYI did a quick test - with an update to the aca-py version the BC Reg issuer is still able to register on startup (i.e. the issuer registration plug-in is working with an updated aca-py) but credential issuing is failing. Not sure why looking into it ...

Yes, that's the behavior I was seeing too.

@ianco
Copy link
Contributor

ianco commented May 22, 2024

Yes, that's the behavior I was seeing too.

Something on the OrgBook side ...

@ianco
Copy link
Contributor

ianco commented May 22, 2024

Hah issue credential 2.0 was already implemented in OrgBook by @amanji

@esune
Copy link
Member Author

esune commented May 22, 2024

Hah issue credential 2.0 was already implemented in OrgBook by @amanji

So the protocol is not the issue we're looking for? 🙂

@ianco
Copy link
Contributor

ianco commented May 22, 2024

Well theoretically both the V10 and V20 protocols should work. The BC Reg issuer is issuing using V10 which is breaking with the newer aca-py version. I'll figure that out and then also try testing the issuer using the V20 protocol.

@ianco
Copy link
Contributor

ianco commented May 23, 2024

I believe the cause is the "abbreviated webhooks" fix, where we don't send the entire payload with the webhook. There's a --debug-webhook option on aca-py, I think we just need to enable this. Just testing now but it should be a fairly simple fix ...

@ianco
Copy link
Contributor

ianco commented May 23, 2024

See PR #783

I think this repo needs to be updated? --> https://github.com/bcgov/orgbook-configurations

@WadeBarnes
Copy link
Member

Thanks @ianco, I can update the other repo. I'll likely use the env var form of the config to enable that. Does that only need to be enabled on the OrgBook (holder) side?

@ianco
Copy link
Contributor

ianco commented May 23, 2024

Does that only need to be enabled on the OrgBook (holder) side?

Yes, just on the OrgBook side. The issuer is fine, no changes required.

PS for my local testing I used the updated aca-py for both issuer and OrgBook (they both use the same image built by the aries-vcr docker scripts). Theoretically it should still work it we update OrgBook but leave the issuer on the older aca-py version, we may want to test that in our test environment ...

@WadeBarnes
Copy link
Member

@ianco ianco closed this as completed Sep 6, 2024
@github-project-automation github-project-automation bot moved this from Assigned to Complete in CDT Enterprise Apps Sep 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

No branches or pull requests

3 participants