Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BccButton disabled doesn't work in combination with the :is component param #316

Open
StevenMalaihollo opened this issue Sep 16, 2024 · 1 comment
Labels
bug Something isn't working as intended

Comments

@StevenMalaihollo
Copy link
Contributor

Describe the bug

image

When setting the BccButton to disabled while using the is to enter in the component that the button is supposed to be, the disabled state is not taken into account.

Expected behavior

The styling and functionality of the disabled state should continue working when using the RouterLink component as BccButtons param.

root cause: commit_id

@StevenMalaihollo StevenMalaihollo added the bug Something isn't working as intended label Sep 16, 2024
@laurensgroeneveld
Copy link
Collaborator

This is because the :disabled modifier is used to set the styles, but the disabled attribute only works on a button not an a element (even though it is set, it doesn't take effect). https://github.com/bcc-code/bcc-design/blob/main/design-library/src/components/BccButton/BccButton.css#L4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working as intended
Projects
None yet
Development

No branches or pull requests

2 participants