diff --git a/bcbio/cwl/cwlutils.py b/bcbio/cwl/cwlutils.py index a1319d375..be64ff013 100644 --- a/bcbio/cwl/cwlutils.py +++ b/bcbio/cwl/cwlutils.py @@ -92,7 +92,26 @@ def unpack_tarballs(xs, data, use_subdir=True): if not os.path.exists(out_dir): with utils.chdir(tarball_dir): with tarfile.open(xs, "r:gz") as tar: - tar.extractall() + def is_within_directory(directory, target): + + abs_directory = os.path.abspath(directory) + abs_target = os.path.abspath(target) + + prefix = os.path.commonprefix([abs_directory, abs_target]) + + return prefix == abs_directory + + def safe_extract(tar, path=".", members=None, *, numeric_owner=False): + + for member in tar.getmembers(): + member_path = os.path.join(path, member.name) + if not is_within_directory(path, member_path): + raise Exception("Attempted Path Traversal in Tar File") + + tar.extractall(path, members, numeric_owner=numeric_owner) + + + safe_extract(tar) assert os.path.exists(out_dir), out_dir # Default to representing output directory xs = out_dir