Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Master commits break projects using the latest version #709

Open
marioarranzr opened this issue Oct 18, 2022 · 3 comments
Open

Master commits break projects using the latest version #709

marioarranzr opened this issue Oct 18, 2022 · 3 comments

Comments

@marioarranzr
Copy link

Hi, @bbyars thanks for this project, super useful library for bdd tests and reproducing different scenarios.

We've recently had an issue due to a change in the entrypoint in the master branch so I thought I would open a ticket to ask for branch commits instead of committing to master directly.
I know we should have pointed to a version tag instead of to latest but I think it's a good practise that is worth mentioning.

Thanks again for all the effort maintaining the library!

@bbyars
Copy link
Owner

bbyars commented Oct 22, 2022 via email

@marioarranzr
Copy link
Author

When using docker and referring to the library as image: bbyars/mountebank it points to master directly, so it's up to date with every master commit.
I know that is not the best practise, it should always point to a specific tag (image: bbyars/mountebank:2.8.1).
But I thought it was worth mentioning that committing to a branch and merge once it works is cleaner and groups related commits in a single commit to master.

@brunns
Copy link
Contributor

brunns commented Oct 24, 2022

There are certainly those who argue the opposite, that trunk based development is the better way to go.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants