Move the Reverb URL to env config

Author: alex-magana

envConfig/live.env

@@ -23,6 +23,9 @@ AWS_EMF_SERVICE_NAME=Simorgh
 AWS_EMF_LOG_GROUP_NAME=SimorghServer
 AWS_EMF_ENVIRONMENT=EC2
 
+# Reverb Reporting
+SIMORGH_REVERB_SOURCE=https://mybbc-analytics.files.bbci.co.uk/reverb-client-js/reverb-3.9.2.js
+
 ## WebVitals Reporting
 SIMORGH_WEBVITALS_REPORTING_ENDPOINT=https://ws.bbc-reporting-api.app/report-endpoint 
 SIMORGH_WEBVITALS_DEFAULT_SAMPLING_RATE=20

envConfig/local.env

@@ -23,6 +23,9 @@ AWS_EMF_SERVICE_NAME=Simorgh
 AWS_EMF_LOG_GROUP_NAME=SimorghServer
 AWS_EMF_ENVIRONMENT=Local
 
+# Reverb Reporting
+SIMORGH_REVERB_SOURCE=https://mybbc-analytics.files.bbci.co.uk/reverb-client-js/reverb-3.9.2.js
+
 ## WebVitals Reporting
 SIMORGH_WEBVITALS_REPORTING_ENDPOINT=https://ws.bbc-reporting-api.app/report-endpoint 
 SIMORGH_WEBVITALS_DEFAULT_SAMPLING_RATE=100

envConfig/preview1.env

@@ -23,6 +23,9 @@ AWS_EMF_SERVICE_NAME=Simorgh
 AWS_EMF_LOG_GROUP_NAME=SimorghServer
 AWS_EMF_ENVIRONMENT=EC2
 
+# Reverb Reporting
+SIMORGH_REVERB_SOURCE=https://mybbc-analytics.files.bbci.co.uk/reverb-client-js/reverb-3.9.2.js
+
 ## WebVitals Reporting
 SIMORGH_WEBVITALS_REPORTING_ENDPOINT=https://ws.bbc-reporting-api.app/report-endpoint 
 SIMORGH_WEBVITALS_DEFAULT_SAMPLING_RATE=100

envConfig/preview2.env

@@ -23,6 +23,9 @@ AWS_EMF_SERVICE_NAME=Simorgh
 AWS_EMF_LOG_GROUP_NAME=SimorghServer
 AWS_EMF_ENVIRONMENT=EC2
 
+# Reverb Reporting
+SIMORGH_REVERB_SOURCE=https://mybbc-analytics.files.bbci.co.uk/reverb-client-js/reverb-3.9.2.js
+
 ## WebVitals Reporting
 SIMORGH_WEBVITALS_REPORTING_ENDPOINT=https://ws.bbc-reporting-api.app/report-endpoint 
 SIMORGH_WEBVITALS_DEFAULT_SAMPLING_RATE=100

envConfig/test.env

@@ -23,6 +23,9 @@ AWS_EMF_SERVICE_NAME=Simorgh
 AWS_EMF_LOG_GROUP_NAME=SimorghServer
 AWS_EMF_ENVIRONMENT=EC2
 
+# Reverb Reporting
+SIMORGH_REVERB_SOURCE=https://mybbc-analytics.files.bbci.co.uk/reverb-client-js/reverb-3.9.2.js
+
 ## WebVitals Reporting
 SIMORGH_WEBVITALS_REPORTING_ENDPOINT=https://ws.bbc-reporting-api.app/report-endpoint 
 SIMORGH_WEBVITALS_DEFAULT_SAMPLING_RATE=100

src/app/lib/utilities/getEnvConfig/index.ts

@@ -23,6 +23,7 @@ export const getProcessEnvAppVariables = () => ({
     process.env.SIMORGH_PUBLIC_STATIC_ASSETS_ORIGIN,
   SIMORGH_PUBLIC_STATIC_ASSETS_PATH:
     process.env.SIMORGH_PUBLIC_STATIC_ASSETS_PATH,
+  SIMORGH_REVERB_SOURCE: process.env.SIMORGH_REVERB_SOURCE,
   SIMORGH_WEBVITALS_REPORTING_ENDPOINT:
     process.env.SIMORGH_WEBVITALS_REPORTING_ENDPOINT,
   SIMORGH_WEBVITALS_DEFAULT_SAMPLING_RATE:

src/integration/utils/customResourceLoader.js

@@ -1,11 +1,9 @@
 const jsdom = require('jsdom');
+const dotenv = require('dotenv');
 
 class CustomResourceLoader extends jsdom.ResourceLoader {
   fetch(url, options) {
-    if (
-      url ===
-      'https://mybbc-analytics.files.bbci.co.uk/reverb-client-js/reverb-3.9.2.js'
-    ) {
+    if (url === dotenv.config().parsed.SIMORGH_REVERB_SOURCE) {
       return super.fetch(url, options);
     }
 

src/server/Document/Renderers/CanonicalRenderer.tsx

@@ -2,7 +2,10 @@
 import React from 'react';
 import IfAboveIE9 from '#app/legacy/components/IfAboveIE9Comment';
 import NO_JS_CLASSNAME from '#app/lib/noJs.const';
-import { getProcessEnvAppVariables } from '#app/lib/utilities/getEnvConfig';
+import {
+  getEnvConfig,
+  getProcessEnvAppVariables,
+} from '#app/lib/utilities/getEnvConfig';
 import serialiseForScript from '#app/lib/utilities/serialiseForScript';
 import { BaseRendererProps } from './types';
 
@@ -49,10 +52,7 @@ export default function CanonicalRenderer({
             }, 5000);`,
           }}
         />
-        <script
-          async
-          src="https://mybbc-analytics.files.bbci.co.uk/reverb-client-js/reverb-3.9.2.js"
-        />
+        <script async src={`${getEnvConfig().SIMORGH_REVERB_SOURCE}`} />
 
         {isApp && <meta name="robots" content="noindex" />}
         {title}