Skip to content

Commit 94e3407

Browse files
authored
Merge pull request #12484 from bbc/WORLDSERVICE-413-bug-audio-pages-unclickable-links
WORLDSERVICE-413 Audio pages podcast provider links unclickable on desktop
2 parents acb4db9 + 32a01c1 commit 94e3407

File tree

8 files changed

+9
-18
lines changed

8 files changed

+9
-18
lines changed

cypress/e2e/specialFeatures/atiAnalytics/assertions/podcastLinks.js

+1-3
Original file line numberDiff line numberDiff line change
@@ -42,9 +42,7 @@ export const assertPodcastLinksComponentClick = ({
4242
});
4343

4444
// Click on the RSS link
45-
cy.get('[data-e2e="podcast-links"]')
46-
.contains('RSS')
47-
.click({ force: true });
45+
cy.get('[data-e2e="podcast-links"]').contains('RSS').click();
4846

4947
assertATIComponentClickEvent({
5048
component: PODCAST_LINKS,

cypress/e2e/specialFeatures/atiAnalytics/assertions/podcastPromo.js

+1-4
Original file line numberDiff line numberDiff line change
@@ -42,10 +42,7 @@ export const assertPodcastPromoComponentClick = ({
4242
});
4343

4444
// Click on first item
45-
cy.get('[data-e2e="podcast-promo"]')
46-
.find('a')
47-
.last()
48-
.click({ force: true });
45+
cy.get('[data-e2e="podcast-promo"]').find('a').last().click();
4946

5047
assertATIComponentClickEvent({
5148
component: PODCAST_PROMO,

cypress/e2e/specialFeatures/atiAnalytics/assertions/radioSchedule.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -42,7 +42,7 @@ export const assertRadioScheduleComponentClick = ({
4242
});
4343

4444
// Click on last item which will be an on-demand episode
45-
cy.get('[data-e2e="onDemand"]').find('a').first().click({ force: true });
45+
cy.get('[data-e2e="onDemand"]').find('a').first().click();
4646

4747
assertATIComponentClickEvent({
4848
component: RADIO_SCHEDULE,

cypress/e2e/specialFeatures/atiAnalytics/assertions/recentAudioEpisodes.js

+1-4
Original file line numberDiff line numberDiff line change
@@ -42,10 +42,7 @@ export const assertRecentAudioEpisodesComponentClick = ({
4242
});
4343

4444
// Click on first item
45-
cy.get('[data-e2e="recent-episodes-list"]')
46-
.find('a')
47-
.first()
48-
.click({ force: true });
45+
cy.get('[data-e2e="recent-episodes-list"]').find('a').first().click();
4946

5047
assertATIComponentClickEvent({
5148
component: RECENT_AUDIO_EPISODES,

cypress/support/config/settings.js

+1-4
Original file line numberDiff line numberDiff line change
@@ -6285,10 +6285,7 @@ module.exports = () => ({
62856285
paths: ['/ukrainian/topics/c61k92vrqz6t'], // ukrainian in russian
62866286
enabled: true,
62876287
},
6288-
local: {
6289-
paths: [],
6290-
enabled: false,
6291-
},
6288+
local: { paths: [], enabled: false },
62926289
},
62936290
smoke: false,
62946291
},

src/app/components/MediaLoader/configs/audio.ts

+1
Original file line numberDiff line numberDiff line change
@@ -34,6 +34,7 @@ export default ({
3434
...basePlayerConfig.ui,
3535
...AUDIO_UI_CONFIG,
3636
},
37+
superResponsive: false,
3738
},
3839
mediaType: 'audio',
3940
showAds: false,

src/app/components/MediaLoader/configs/liveRadio.ts

+1
Original file line numberDiff line numberDiff line change
@@ -45,6 +45,7 @@ export default ({
4545
...basePlayerConfig.ui,
4646
...AUDIO_UI_CONFIG,
4747
},
48+
superResponsive: false,
4849
},
4950
mediaType: 'liveRadio',
5051
showAds: false,

src/app/components/MediaLoader/utils/buildSettings.test.ts

+2-2
Original file line numberDiff line numberDiff line change
@@ -928,7 +928,6 @@ describe('buildSettings', () => {
928928
appType: 'responsive',
929929
autoplay: false,
930930
counterName: 'hausa.bbc_hausa_radio.liveradio.page',
931-
superResponsive: true,
932931
playlistObject: {
933932
items: [
934933
{
@@ -966,6 +965,7 @@ describe('buildSettings', () => {
966965
enabled: true,
967966
},
968967
},
968+
superResponsive: false,
969969
},
970970
mediaType: 'liveRadio',
971971
showAds: false,
@@ -1011,7 +1011,7 @@ describe('buildSettings', () => {
10111011
autoplay: false,
10121012
appName: 'news-afrique',
10131013
counterName: 'afrique.bbc_afrique_radio.w172zn0kxd65h3g.page',
1014-
superResponsive: true,
1014+
superResponsive: false,
10151015
statsObject: {
10161016
destination: 'WS_NEWS_LANGUAGES',
10171017
producer: 'AFRIQUE',

0 commit comments

Comments
 (0)