From 21c2ae34b9c92464bfe6b3349df311bf75b742e8 Mon Sep 17 00:00:00 2001 From: alex-magana Date: Tue, 4 Feb 2025 16:01:59 +0300 Subject: [PATCH 1/4] Remove hashedId from Reverb page view beacon config --- src/app/components/ATIAnalytics/atiUrl/index.ts | 1 - src/app/lib/analyticsUtils/sendBeacon/index.js | 2 +- 2 files changed, 1 insertion(+), 2 deletions(-) diff --git a/src/app/components/ATIAnalytics/atiUrl/index.ts b/src/app/components/ATIAnalytics/atiUrl/index.ts index 6b1256eb5a4..b9f41dfbb91 100644 --- a/src/app/components/ATIAnalytics/atiUrl/index.ts +++ b/src/app/components/ATIAnalytics/atiUrl/index.ts @@ -479,7 +479,6 @@ export const buildReverbAnalyticsModel = ({ }, }, user: { - hashedId: getAtUserId(), isSignedIn: false, }, }, diff --git a/src/app/lib/analyticsUtils/sendBeacon/index.js b/src/app/lib/analyticsUtils/sendBeacon/index.js index 3fafd914294..a8078dfbfd2 100644 --- a/src/app/lib/analyticsUtils/sendBeacon/index.js +++ b/src/app/lib/analyticsUtils/sendBeacon/index.js @@ -47,7 +47,7 @@ const setReverbPageValues = async ({ pageVars, userVars }) => { }); window.bbcuser = { - getHashedId: () => [userVars.hashedId], + getHashedId: () => null, isSignedIn: () => Promise.resolve(userVars.isSignedIn), }; }; From 3fc101713f4185bf3a2b7e3a8d53303554db9751 Mon Sep 17 00:00:00 2001 From: alex-magana Date: Tue, 4 Feb 2025 16:25:42 +0300 Subject: [PATCH 2/4] Remove hashedId from the Reverb component click and view tracking beacon config --- src/app/components/ATIAnalytics/atiUrl/index.ts | 1 - 1 file changed, 1 deletion(-) diff --git a/src/app/components/ATIAnalytics/atiUrl/index.ts b/src/app/components/ATIAnalytics/atiUrl/index.ts index b9f41dfbb91..9b40df85e19 100644 --- a/src/app/components/ATIAnalytics/atiUrl/index.ts +++ b/src/app/components/ATIAnalytics/atiUrl/index.ts @@ -528,7 +528,6 @@ export const buildReverbPageSectionEventModel = ({ }, }, user: { - hashedId: getAtUserId(), isSignedIn: false, }, }, From eaf084233f160f1bcfbd083e8571ad98ab688a26 Mon Sep 17 00:00:00 2001 From: alex-magana Date: Tue, 4 Feb 2025 17:44:31 +0300 Subject: [PATCH 3/4] Add tests to assert user object structure --- src/app/components/ATIAnalytics/atiUrl/index.test.ts | 12 ++++++++++++ 1 file changed, 12 insertions(+) diff --git a/src/app/components/ATIAnalytics/atiUrl/index.test.ts b/src/app/components/ATIAnalytics/atiUrl/index.test.ts index 7f9ad991e74..74a56ad2a8d 100644 --- a/src/app/components/ATIAnalytics/atiUrl/index.test.ts +++ b/src/app/components/ATIAnalytics/atiUrl/index.test.ts @@ -357,8 +357,11 @@ describe('Reverb', () => { x18: 'isLocServeCookieSet', }, }; + const userParans = { isSignedIn: false }; expect(reverbAnalyticsModel.params.page).toEqual(pageParams); + expect(reverbAnalyticsModel.params.user).toEqual(userParans); + expect(reverbAnalyticsModel.eventDetails).toEqual({ eventName: 'pageView', }); @@ -439,5 +442,14 @@ describe('Reverb', () => { container: '1234', }); }); + + it('should return the correct Reverb user object configuration', () => { + const reverbPageSectionViewEventModel = + buildReverbPageSectionEventModel(input); + + expect(reverbPageSectionViewEventModel.params.user).toEqual( + { isSignedIn: false } + ); + }); }); }); From 7790665563283ad0ea8b3eb26ecf6e11914b3807 Mon Sep 17 00:00:00 2001 From: alex-magana Date: Tue, 4 Feb 2025 18:42:41 +0300 Subject: [PATCH 4/4] Fix linting error --- src/app/components/ATIAnalytics/atiUrl/index.test.ts | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/app/components/ATIAnalytics/atiUrl/index.test.ts b/src/app/components/ATIAnalytics/atiUrl/index.test.ts index 74a56ad2a8d..f782af45a9f 100644 --- a/src/app/components/ATIAnalytics/atiUrl/index.test.ts +++ b/src/app/components/ATIAnalytics/atiUrl/index.test.ts @@ -447,9 +447,9 @@ describe('Reverb', () => { const reverbPageSectionViewEventModel = buildReverbPageSectionEventModel(input); - expect(reverbPageSectionViewEventModel.params.user).toEqual( - { isSignedIn: false } - ); + expect(reverbPageSectionViewEventModel.params.user).toEqual({ + isSignedIn: false, + }); }); }); });