From 44ac3b43098cdd2e01d1ab2450e0d643bf2cb8d1 Mon Sep 17 00:00:00 2001 From: ppbra Date: Thu, 27 Dec 2018 13:56:58 +0700 Subject: [PATCH] update --- controller/admin.controller.js | 10 +++------- controller/teacher.controller.js | 11 +++++++++-- 2 files changed, 12 insertions(+), 9 deletions(-) diff --git a/controller/admin.controller.js b/controller/admin.controller.js index b41fee7..ebd1542 100644 --- a/controller/admin.controller.js +++ b/controller/admin.controller.js @@ -352,15 +352,11 @@ module.exports = { let count = 0; - studentSurveys.forEach(e => { - if (surveyChecker.verify(e)) { - count++; - } - }) - - if (studentSurveys) { studentSurveys.forEach(e => { + if (surveyChecker.verify(e)) { + count++; + } if (!!e.comment) { comments.push(e.comment); } diff --git a/controller/teacher.controller.js b/controller/teacher.controller.js index 5debd46..993b3a2 100644 --- a/controller/teacher.controller.js +++ b/controller/teacher.controller.js @@ -3,6 +3,7 @@ const ClassSurvey = require('../models/classSurvey.model'); const Class = require('../models/class.model'); const StudentSurvey = require('../models/studentSurvey.model'); +const surveyChecker = require('../common/validateSurvey'); const response = require('../common/response'); module.exports = { @@ -41,15 +42,21 @@ module.exports = { const isHaveClass = teacherClasses.find(e => e.id === classId); const studentSurveys = await StudentSurvey.find({ class: classId }); const comments = []; + let count = 0; if (studentSurveys) { studentSurveys.forEach(e => { + if (surveyChecker.verify(e)) { + count++; + } + if (!!e.comment) { comments.push(e.comment); } }) } + if (isHaveClass) { const classSurvey = await ClassSurvey.findById(classId); console.log(classSurvey); @@ -61,7 +68,7 @@ module.exports = { last_modify: classSurvey.last_modify, deadline: classSurvey.deadline, comments: comments, - count_of_students: studentSurveys.length + count_of_students: count } response.success(res, classSurveyTmp); } @@ -86,7 +93,7 @@ module.exports = { id: classId, name: isExistClass.name }); - teachers.findEach(e => { + teachers.forEach(e => { if (e.id !== userId) { for (let i = 0; i < e.class.length; i++) { if (e.class[i].id === classId) {