Skip to content

Commit c661155

Browse files
authored
Migrate rules_js rules and tests to external module (#3630)
The rules have been migrated to https://github.com/UebelAndre/rules_js_rust_wasm_bindgen
1 parent 41c0ffb commit c661155

File tree

10 files changed

+1
-257
lines changed

10 files changed

+1
-257
lines changed

.pre-commit-config.yaml

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -38,8 +38,3 @@ repos:
3838
exclude_types:
3939
- json
4040
- javascript
41-
- repo: https://github.com/pre-commit/mirrors-prettier
42-
rev: v3.1.0
43-
hooks:
44-
- id: prettier
45-
files: ".*\\.(js|mjs|cjs|jsx|ts|tsx)$"

docs/BUILD.bazel

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -249,13 +249,6 @@ stardoc(
249249
deps = ["@rules_rust_wasm_bindgen//:bzl_lib"],
250250
)
251251

252-
stardoc(
253-
name = "rust_wasm_bindgen_rules_js",
254-
out = "src/rust_wasm_bindgen_rules_js.md",
255-
input = "@rules_rust_wasm_bindgen//rules_js:defs.bzl",
256-
deps = ["@rules_rust_wasm_bindgen//rules_js:bzl_lib"],
257-
)
258-
259252
stardoc(
260253
name = "rust_settings",
261254
out = "src/rust_settings.md",
@@ -295,7 +288,6 @@ mdbook(
295288
":rust_toolchains",
296289
":rust_unpretty",
297290
":rust_wasm_bindgen",
298-
":rust_wasm_bindgen_rules_js",
299291
],
300292
book = "book.toml",
301293
)

extensions/wasm_bindgen/.bazelrc

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -5,9 +5,6 @@
55
## https://bazel.build/docs/best-practices#bazelrc-file
66
###############################################################################
77

8-
# TODO: https://github.com/bazelbuild/rules_rust/issues/3319
9-
common --deleted_packages=rules_js,rules_js/test
10-
118
# An alias for the test browser setting.
129
common --flag_alias=test_browser=//settings:test_browser
1310

extensions/wasm_bindgen/MODULE.bazel

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,6 @@ bazel_dep(name = "bazel_features", version = "1.32.0")
1010
bazel_dep(name = "bazel_skylib", version = "1.8.1")
1111
bazel_dep(name = "platforms", version = "1.0.0")
1212
bazel_dep(name = "rules_cc", version = "0.2.4")
13-
bazel_dep(name = "aspect_rules_js", version = "2.1.2")
1413
bazel_dep(name = "apple_support", version = "1.23.0")
1514

1615
rust_ext = use_extension("//:extensions.bzl", "rust_ext")

extensions/wasm_bindgen/defs.bzl

Lines changed: 1 addition & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -29,13 +29,7 @@ toolchains to register in the workspace.
2929
3030
## Interfacing with Javascript rules
3131
32-
While it's recommended for users to maintain their own , in the
33-
`@rules_rust_wasm_bindgen` package there exists interface sub-packages for various
34-
Javascript Bazel rules. E.g. `aspect_rules_js`. The rules defined there are a more
35-
convenient way to use `rust_wasm_bindgen` with the associated javascript rules due
36-
to the inclusion of additional providers. Each directory contains a `defs.bzl` file
37-
that defines the different variants of `rust_wasm_bindgen`. (e.g. `js_rust_wasm_bindgen`
38-
for the `rules_js` submodule).
32+
Rules for doing so can be found at [rules_js_rust_wasm_bindgen](https://github.com/UebelAndre/rules_js_rust_wasm_bindgen)
3933
4034
4135
[wb]: https://github.com/rustwasm/wasm-bindgen

extensions/wasm_bindgen/rules_js/BUILD.bazel

Lines changed: 0 additions & 17 deletions
This file was deleted.

extensions/wasm_bindgen/rules_js/defs.bzl

Lines changed: 0 additions & 59 deletions
This file was deleted.

extensions/wasm_bindgen/rules_js/repositories.bzl

Lines changed: 0 additions & 23 deletions
This file was deleted.

extensions/wasm_bindgen/rules_js/test/BUILD.bazel

Lines changed: 0 additions & 104 deletions
This file was deleted.

extensions/wasm_bindgen/rules_js/test/hello_world_wasm_test.js

Lines changed: 0 additions & 30 deletions
This file was deleted.

0 commit comments

Comments
 (0)