Skip to content

Commit 63382b1

Browse files
committed
Allow using MODULE.bazel.lock files to speed up crate_universe tests
1 parent c9f69c1 commit 63382b1

File tree

3 files changed

+16377
-18
lines changed

3 files changed

+16377
-18
lines changed

.bazelci/presubmit.yml

+22-15
Original file line numberDiff line numberDiff line change
@@ -75,6 +75,12 @@ default_windows_no_runfiles_targets: &default_windows_no_runfiles_targets
7575
- "-//tools/runfiles/..."
7676
# Runfiles used by the test only.
7777
- "-//test/empty_suite:deps_test"
78+
crate_universe_example_shell_commands: &crate_universe_example_shell_commands
79+
- rm MODULE.bazel.lock
80+
crate_universe_example_rbe_shell_commands: &crate_universe_example_rbe_shell_commands
81+
- rm MODULE.bazel.lock
82+
- sed -i 's/^# load("@bazel_ci_rules/load("@bazel_ci_rules/' WORKSPACE.bazel
83+
- sed -i 's/^# rbe_preconfig/rbe_preconfig/' WORKSPACE.bazel
7884
crate_universe_vendor_example_targets: &crate_universe_vendor_example_targets
7985
- "//vendor_external:crates_vendor"
8086
- "//vendor_local_manifests:crates_vendor"
@@ -435,6 +441,7 @@ tasks:
435441
name: Crate Universe Examples
436442
platform: ubuntu2004
437443
working_directory: examples/crate_universe
444+
shell_commands: *crate_universe_example_shell_commands
438445
run_targets: *crate_universe_vendor_example_targets
439446
build_targets:
440447
- "//..."
@@ -445,9 +452,7 @@ tasks:
445452
name: Crate Universe Examples
446453
platform: rbe_ubuntu2004
447454
working_directory: examples/crate_universe
448-
shell_commands:
449-
- sed -i 's/^# load("@bazel_ci_rules/load("@bazel_ci_rules/' WORKSPACE.bazel
450-
- sed -i 's/^# rbe_preconfig/rbe_preconfig/' WORKSPACE.bazel
455+
shell_commands: *crate_universe_example_rbe_shell_commands
451456
run_targets: *crate_universe_vendor_example_targets
452457
build_targets:
453458
- "--"
@@ -464,12 +469,25 @@ tasks:
464469
name: Crate Universe Examples
465470
platform: macos_arm64
466471
working_directory: examples/crate_universe
472+
shell_commands: *crate_universe_example_shell_commands
467473
run_targets: *crate_universe_vendor_example_targets
474+
build_flags: *aspects_flags
468475
build_targets:
469476
- "//..."
470477
test_targets:
471478
- "//..."
472-
build_flags: *aspects_flags
479+
# See https://github.com/bazelbuild/rules_rust/issues/2186 about re-enabling these.
480+
# crate_universe_examples_windows:
481+
# name: Crate Universe Examples
482+
# platform: windows
483+
# working_directory: examples/crate_universe
484+
# shell_commands: *crate_universe_example_shell_commands
485+
# run_targets: *crate_universe_vendor_example_targets
486+
# build_flags: *aspects_flags
487+
# build_targets:
488+
# - "//..."
489+
# test_targets:
490+
# - "//..."
473491
crate_universe_local_path_external:
474492
name: Crate Universe Local Path External
475493
platform: ubuntu2004
@@ -498,17 +516,6 @@ tasks:
498516
working_directory: examples/crate_universe_local_path
499517
run_targets:
500518
- "//:vendor_edit_test_in_tree"
501-
# See https://github.com/bazelbuild/rules_rust/issues/2186 about re-enabling these.
502-
# crate_universe_examples_windows:
503-
# name: Crate Universe Examples
504-
# platform: windows
505-
# working_directory: examples/crate_universe
506-
# run_targets: *crate_universe_vendor_example_targets
507-
# build_flags: *aspects_flags
508-
# build_targets:
509-
# - "//..."
510-
# test_targets:
511-
# - "//..."
512519
cc_common_link_ubuntu2004:
513520
name: Build via cc_common.link
514521
platform: ubuntu2004

examples/crate_universe/.bazelrc

-3
Original file line numberDiff line numberDiff line change
@@ -37,9 +37,6 @@ build --incompatible_merge_fixed_and_default_shell_env
3737
# A configuration for disabling bzlmod.
3838
common:no-bzlmod --noenable_bzlmod --enable_workspace
3939

40-
# Disable the bzlmod lockfile, so we don't accidentally commit MODULE.bazel.lock
41-
common --lockfile_mode=off
42-
4340
###############################################################################
4441
## Custom user flags
4542
##

0 commit comments

Comments
 (0)