bugfix: l-bfgs-b acquisition maximization (#563)

* bugfix: l-bfgs-b acq

* Update runner

* Slightly relax equivalency check

* bump version

Author: till-m

.github/workflows/build_docs.yml

@@ -13,7 +13,7 @@ concurrency:
 
 jobs:
   build-docs-and-publish:
-    runs-on: ubuntu-20.04
+    runs-on: ubuntu-latest
     permissions:
       contents: write
     steps:

bayes_opt/acquisition.py

@@ -300,7 +300,7 @@ def _l_bfgs_b_minimize(
                 continue
 
             # Store it if better than previous minimum(maximum).
-            if min_acq is None or np.squeeze(res.fun) >= min_acq:
+            if min_acq is None or np.squeeze(res.fun) <= min_acq:
                 x_min = res.x
                 min_acq = np.squeeze(res.fun)
 

pyproject.toml

@@ -1,6 +1,6 @@
 [tool.poetry]
 name = "bayesian-optimization"
-version = "2.0.3"
+version = "2.0.4"
 description = "Bayesian Optimization package"
 authors = ["Fernando Nogueira"]
 license = "MIT"

tests/test_constraint.py

@@ -89,9 +89,9 @@ def test_single_constraint_lower_upper(target_function, constraint_function):
     y = res[:, 3]
 
     # Check accuracy of approximation for sampled points
-    assert constraint_function(x, y) == pytest.approx(optimizer.constraint.approx(xy), rel=1e-5, abs=1e-5)
+    assert constraint_function(x, y) == pytest.approx(optimizer.constraint.approx(xy), rel=1e-4, abs=1e-4)
     assert constraint_function(x, y) == pytest.approx(
-        optimizer.space.constraint_values[:-1], rel=1e-5, abs=1e-5
+        optimizer.space.constraint_values[:-1], rel=1e-4, abs=1e-4
     )