follow shellchecks recommendations to quote everything

and also add a shebang where previously was none.

Author: klaernie

build.sh

@@ -4,7 +4,7 @@ set -e
 # https://stackoverflow.com/a/51761312/4934537
 latest_release=$(git ls-remote --tags --refs --sort="v:refname" https://github.com/MichMich/MagicMirror.git | tail -n1 | sed 's/.*\///')
 if [ "$(docker manifest inspect bastilimbach/docker-magicmirror:"${latest_release}" > /dev/null; echo $?)" != 0 ]; then
-  docker buildx build --progress plain --platform=linux/amd64,linux/arm64,linux/arm/v7 ${1} --build-arg branch="${latest_release}" -t bastilimbach/docker-magicmirror:"${latest_release}" -t bastilimbach/docker-magicmirror:latest .
+  docker buildx build --progress plain --platform=linux/amd64,linux/arm64,linux/arm/v7 "${1}" --build-arg branch="${latest_release}" -t bastilimbach/docker-magicmirror:"${latest_release}" -t bastilimbach/docker-magicmirror:latest .
 fi
 
-docker buildx build --progress plain --platform=linux/amd64,linux/arm64,linux/arm/v7 ${1} --build-arg branch=develop -t bastilimbach/docker-magicmirror:develop .
+docker buildx build --progress plain --platform=linux/amd64,linux/arm64,linux/arm/v7 "${1}" --build-arg branch=develop -t bastilimbach/docker-magicmirror:develop .

test-build.sh

@@ -1,3 +1,5 @@
+#!/bin/bash
+
 rm -rf ./config
 rm -rf ./modules
 mkdir config
@@ -8,7 +10,7 @@ docker build -t mm:latest .
 docker run  -d \
 	--publish 80:8080 \
 	--restart always \
-	--volume $PWD/config:/opt/magic_mirror/config \
-	--volume $PWD/modules:/opt/magic_mirror/modules \
+	--volume "$PWD"/config:/opt/magic_mirror/config \
+	--volume "$PWD"/modules:/opt/magic_mirror/modules \
 	--name magic_mirror \
 	mm:latest