-
-
Notifications
You must be signed in to change notification settings - Fork 786
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a "Badge" Service #356
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: Frédéric Pégé <[email protected]>
Signed-off-by: Frédéric Pégé <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @h4wkmoon,
That's a good idea, why not adding it to the Generic base component to any card could have an image in the indicator slot? That would be great!
Sorry for the delayed review, and thank you for the contribution !
Signed-off-by: Frédéric Pégé <[email protected]> Co-authored-by: Bastien Wirtz <[email protected]>
That could have been done, but that would have been disruptive. Doing it like I did, I more confident I don't break your code, or the existing deployments. Adding a new feature is always easier and less risky than modifiying existing ones. As I'm not a dev, especially in vue, I more prone to mistakes. |
Would it be ok if I merge your contribution into a branch, rework it to integrate it safely into the generic base component and then merge it to main ? I really think it coul dbe great to make it available for every component. |
Sure. That would be a good Idea, since you know what you do. |
Any updates on this? I would love to have this feature. Thanks! |
Description
Adding a new service, for badges, like Shields.io
Type of change
Checklist:
config.yml
file