Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a "Badge" Service #356

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Add a "Badge" Service #356

wants to merge 3 commits into from

Conversation

h4wkmoon
Copy link

Description

Adding a new service, for badges, like Shields.io

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • I've read & comply with the contributing guidelines
  • I have tested my code for new features & regressions on both mobile & desktop devices, using the latest version of major browsers.
  • I have made corresponding changes to the documentation (README.md).
  • I've checked my modifications for any breaking changes, especially in the config.yml file

Signed-off-by: Frédéric Pégé <[email protected]>
Signed-off-by: Frédéric Pégé <[email protected]>
Copy link
Owner

@bastienwirtz bastienwirtz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @h4wkmoon,
That's a good idea, why not adding it to the Generic base component to any card could have an image in the indicator slot? That would be great!

Sorry for the delayed review, and thank you for the contribution !

src/components/services/Badge.vue Outdated Show resolved Hide resolved
Signed-off-by: Frédéric Pégé <[email protected]>

Co-authored-by: Bastien Wirtz <[email protected]>
@h4wkmoon
Copy link
Author

h4wkmoon commented Apr 8, 2022

Hey @h4wkmoon, That's a good idea, why not adding it to the Generic base component to any card could have an image in the indicator slot? That would be great!

Sorry for the delayed review, and thank you for the contribution !

That could have been done, but that would have been disruptive. Doing it like I did, I more confident I don't break your code, or the existing deployments. Adding a new feature is always easier and less risky than modifiying existing ones. As I'm not a dev, especially in vue, I more prone to mistakes.

@bastienwirtz
Copy link
Owner

Would it be ok if I merge your contribution into a branch, rework it to integrate it safely into the generic base component and then merge it to main ? I really think it coul dbe great to make it available for every component.

@h4wkmoon
Copy link
Author

Sure. That would be a good Idea, since you know what you do.

@itobey
Copy link

itobey commented Jul 17, 2022

Any updates on this? I would love to have this feature. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants